Date: Tue, 07 Apr 2015 12:47:16 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r383184 - in head/devel/libc++: . files Message-ID: <55241824.2060108@FreeBSD.org> In-Reply-To: <55241047.50102@marino.st> References: <201504040022.t340MwUc082274@svn.freebsd.org> <55240C73.9050209@FreeBSD.org> <55241047.50102@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --txiuij1seC9KeWMRIvuKSlwApdqvncNcA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/7/2015 12:13 PM, John Marino wrote: > On 4/7/2015 18:57, Bryan Drewery wrote: >> On 4/3/2015 7:22 PM, John Marino wrote: >>> Author: marino >>> Date: Sat Apr 4 00:22:57 2015 >>> New Revision: 383184 >>> URL: https://svnweb.freebsd.org/changeset/ports/383184 >>> >>> Log: >>> devel/libc++: Mainly fix DragonFly support. >>> =20 >>> This port was originally fixed in dports using alias:10 but this fi= x >>> was faulty. The libc++ headers reference __FreeBSD__ so alias won'= t >>> work. It needs to be patched to check __DragonFly__, including a f= ile >>> that was the subject of EXTRA_PATCHES. >> >> Can you please upstream the DragonFly support? >> >> I am working on getting dim's patch into the port to update it and >> conflicting with all of this. >=20 > Had I create the patch a week later, then I would have had to rework my= > patch. Sometimes this happen. Dim's PR is from January. PR 196536. >=20 >=20 >> I think it will be simpler to use CPPFLAGS+=3D-D__FreeBSD__ to cover m= ost >> of these cases without patches. >=20 > Well, it didn't. Setting __FreeBSD__ and __FreeBSD_version to 901501 would be the same effect. Though there is a bug from r353085 that incorrectly uses _FreeBSD_version rather than __FreeBSD_version that would need to be fixed for that to work. r353085 | bapt | 2014-05-06 07:20:43 -0500 (Tue, 06 May 2014) | 2 lines Fix build on FreeBSD 9.1 >>> Moreover, the port was installing the .orig files left over from >>> patching. I remove these in post-patch now. >> >> I don't think this is a problem worth fixing. check-plist already >> ignores .orig files. >=20 > Well, it's fixed now so the fix isn't work removing. >=20 The staging/check-plist work resulted in not needing to check options or remove various files from the stagedir. Removing stuff like that is under the cleanup blanket. Generally NOPS in port files are just removed.= --=20 Regards, Bryan Drewery --txiuij1seC9KeWMRIvuKSlwApdqvncNcA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVJBglAAoJEDXXcbtuRpfPgXMIAJ6FSG1jKXqGt4+OiNrpxnV2 awSHJJQljBauVZpaf1SIyayi9rKfboExM9xA//DahcD9gVC3lR/J3b6OlJB3BwkV YkncAIaW/grhKqKJX7wYAFnUFevjvD0e66UfQCaXMpQQZdcUqy/yoVLeN2ISLa+J T/40uaIArtf0NaMUY95HwxDxmaMEPllGqpyvRJud1dVZ/pNmwh9eH9vY9sIQEBcD EdDHWosAaS/ZNVrfC4NXD4WZoyleK8g3yzEIWFrjlkWOFESGQSFciSmJWGDOas4U u//vxBs6B1TDUJtEc2xJsL2VJIV9+JVZdU+zDtb3sFy6PLdiUNOAr6NC1j0Q2lo= =uAUt -----END PGP SIGNATURE----- --txiuij1seC9KeWMRIvuKSlwApdqvncNcA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55241824.2060108>