Date: Tue, 10 Dec 2013 18:48:51 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: Kozlov Sergey <kozlov.sergey.404@gmail.com> Cc: Mathieu Arnold <mat@FreeBSD.org>, Greg Larkin <glarkin@FreeBSD.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r335189 - in head/print/pdftk: . files Message-ID: <alpine.LNX.2.00.1312101845340.2197@tuna.site> In-Reply-To: <52A7471E.6080109@gmail.com> References: <201311291548.rATFm8g7098382@svn.freebsd.org> <alpine.LNX.2.00.1312012257230.2185@tuna.site> <C89CD972357B819FE03015D6@atuin.in.mat.cc> <529C7599.1050509@gmail.com> <alpine.LNX.2.00.1312082235050.2197@tuna.site> <52A7471E.6080109@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 10 Dec 2013, Kozlov Sergey wrote:
> Yes, that's correct. I think the right solution is to add a check if
> gcj is present and give an IGNORE with suggestion to rebuild gcc.
Agreed. If gcj is not present despite that dependency, that's a
good idea. Would you like to propose a patch?
>> LIB_DEPENDS= libgcj.so:${PORTSDIR}/lang/gcc${CSUFF} \
>> libstdc++.so:${PORTSDIR}/lang/gcc${CSUFF} \
>> libgcc_s.so:${PORTSDIR}/lang/gcc${CSUFF}
>>
>> If you insist on libgcj.so, I can accept that, but then let's drop
>> the other two least. This is definitely covered by USE_GCC=yes.
> USE_GCC doesn't add anything to RUN_DEPENDS.
Sure it does:
.if defined(_GCC_PORT_DEPENDS)
BUILD_DEPENDS+= ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT}
. if ${_USE_GCC} != 3.4
RUN_DEPENDS+= ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT}
# Later GCC ports already depend on binutils; make sure whatever we
# build leverages this as well.
USE_BINUTILS= yes
. endif
.endif
> On 08.12.2013 23:39, Gerald Pfeifer wrote:
>> Can I go ahead and just make that
>>
>> LIB_DEPENDS= libgcj.so:${PORTSDIR}/lang/gcc${CSUFF}
>> BUILD_DEPENDS= gcj${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF}
> Generally speaking, I think that's ok but we should really hear the
> opinion of port's maintainer.
Let's see what he thinks. And I am queuing this up on my side to
keep an eye on it.
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1312101845340.2197>