From owner-freebsd-emulation@FreeBSD.ORG  Sat Mar 10 09:00:46 2012
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EF5A0106566B;
	Sat, 10 Mar 2012 09:00:46 +0000 (UTC)
	(envelope-from decke@FreeBSD.org)
Received: from groupware.itac.at (groupware.itac.at [91.205.172.99])
	by mx1.freebsd.org (Postfix) with ESMTP id 827968FC08;
	Sat, 10 Mar 2012 09:00:46 +0000 (UTC)
Received: from home.bluelife.at (93.104.210.95) by groupware.itac.at (Axigen)
	with (AES256-SHA encrypted) ESMTPSA id 391D65;
	Sat, 10 Mar 2012 10:00:22 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Date: Sat, 10 Mar 2012 10:00:10 +0100
From: Bernhard Froehlich <decke@FreeBSD.org>
To: Brandon Gooch <jamesbrandongooch@gmail.com>
In-Reply-To: <CALBk6yK7=59ZMZ+bEurqP_9tDT2OAu4a653N8s2FKKrUTp8L6Q@mail.gmail.com>
References: <CALBk6yK7=59ZMZ+bEurqP_9tDT2OAu4a653N8s2FKKrUTp8L6Q@mail.gmail.com>
Message-ID: <9e02ac1bc0f7a8043f28ced31e319a20@bluelife.at>
X-Sender: decke@FreeBSD.org
User-Agent: Roundcube Webmail/0.7.1
X-AxigenSpam-Level: 1
X-CTCH-RefID: str=0001.0A0B0203.4F5B181A.0076,ss=1,fgs=0
X-CTCH-VOD: Unknown
X-CTCH-Spam: Unknown
Cc: freebsd-emulation@freebsd.org
Subject: Re: [PATCH] VirtualBox 4.1.8 kmod panic with VIMAGE kernel
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Mar 2012 09:00:47 -0000

On 10.03.2012 05:42, Brandon Gooch wrote:
> It's my guess that not many people are running VirtualBox on a
> VIMAGE-enabled kernel.  However, for those of us who do (just me?),
> the attached patch is required to prevent a panic when running
> VirtualBox in such an environment. The patch belongs to the
> emulators/virtualbox-ose-kmod port.
>
> --- src/VBox/HostDrivers/VBoxNetAdp/VBoxNetAdp.c.orig	2011-12-19
> 07:01:06.000000000 -0600
> +++ src/VBox/HostDrivers/VBoxNetAdp/VBoxNetAdp.c	2011-12-26
> 14:54:27.000000000 -0600
> @@ -1189,6 +1189,7 @@
>  int  vboxNetAdpInit(void)
>  {
>      unsigned i;
> +    PVBOXNETADP pVboxnet0;
>      /*
>       * Init common members and call OS-specific init.
>       */
> @@ -1201,7 +1202,8 @@
>          vboxNetAdpOsInit(&g_aAdapters[i]);
>      }
>
> -    return VINF_SUCCESS;
> +    /* Create vboxnet0 */
> +    return vboxNetAdpCreate(&pVboxnet0, NULL);
>  }
>
>  /**
>
> If there is a more appropriate fix, please help me find it, 
> otherwise,
> it would be great to have this committed!

Sorry, that I haven't committed the patch until now. Do you agree that
this patch is licensed under MIT License so I can send it upstream?

Current VIMAGE support is only for vboxnetflt and you are touching
vboxnetadp so that is probably why nobody used it before. Have you
tested it with a non VIMAGE kernel?

-- 
Bernhard Froehlich
http://www.bluelife.at/