From owner-svn-src-projects@freebsd.org Tue Sep 3 14:06:08 2019 Return-Path: Delivered-To: svn-src-projects@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3CD78DC304 for ; Tue, 3 Sep 2019 14:06:05 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7z02t9Zz4P9n; Tue, 3 Sep 2019 14:06:04 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 585DD1A0C5; Tue, 3 Sep 2019 14:05:57 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id DEB236DF8; Tue, 2 Apr 2019 18:49:53 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4201D71DAF; Tue, 2 Apr 2019 18:49:53 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 12E9F6D8E; Tue, 2 Apr 2019 18:49:53 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id A7AE46D8C for ; Tue, 2 Apr 2019 18:49:50 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6222771DAB; Tue, 2 Apr 2019 18:49:50 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f195.google.com with SMTP id f23so12566251ljc.0; Tue, 02 Apr 2019 11:49:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aDWDcvRRrZ3W7zJ/6ytdNtvvA3vcsIEKvj83SWW82VY=; b=nCYof8gXhNclQ3NaKbpBHFiUAYIhZYIdazfsGWGHCK+o8DPZkRtgXw8hExuU8m39Sv DHdQUrgtjuLwmdvt9XdsxEA33opWb/K3gUAOwnnTdQQcT2JuylvYrGZLy4nacJDYVi1o gsCHTzYMRCovlRvFYrLo0SGFZxW1I3+XIxQi9R9E/aSqR0t/Y4A5tGpEz58B0AOtECeA RAghZfy6HWVtGCbnjPoETrNBa+uB478p2XPjeJI5IGuzLsGOoxRwPg1ARzWmivojnSnW RTEedtFKomLFr81L4G3xUAC8840Qkq4UkPx4Bi/mecL66W2+RH3yPWV/tQb3U4sUi9CN ey5w== X-Gm-Message-State: APjAAAU2KxZog/OC6u9bofCMJNd9P9BWgZcRzqc/3XAS2gAZ7FGqlKLD 50dVW3nDFnWtiPdVdqC+6KTjLSBo6Z9gkY0q7KI= X-Google-Smtp-Source: APXvYqz0DCVTkJZDUInnv498/cM3/Ghf99uhUb1kEia85ug3moC2HLlgkVxNF3luGXlpPJHAOGdXYcOyE7uMkkR68Lg= X-Received: by 2002:a2e:9753:: with SMTP id f19mr34377788ljj.54.1554230983091; Tue, 02 Apr 2019 11:49:43 -0700 (PDT) MIME-Version: 1.0 References: <201904021844.x32Ii1wR041319@repo.freebsd.org> <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com> In-Reply-To: <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com> From: Alan Somers Message-ID: Subject: Re: svn commit: r345809 - projects/fuse2/tests/sys/fs/fusefs To: Enji Cooper Cc: src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 4201D71DAF X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:08 -0000 X-Original-Date: Tue, 2 Apr 2019 12:49:31 -0600 X-List-Received-Date: Tue, 03 Sep 2019 14:06:08 -0000 On Tue, Apr 2, 2019 at 12:45 PM Enji Cooper wrote: > > > > On Apr 2, 2019, at 11:44 AM, Alan Somers wrote: > > > > Author: asomers > > Date: Tue Apr 2 18:44:01 2019 > > New Revision: 345809 > > URL: https://svnweb.freebsd.org/changeset/base/345809 > > > > Log: > > fusefs: check return value of wait(2) in fork tests > > > > Reported by: ngie > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > projects/fuse2/tests/sys/fs/fusefs/utils.cc > > > > Modified: projects/fuse2/tests/sys/fs/fusefs/utils.cc > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 18:09:= 40 2019 (r345808) > > +++ projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 18:44:= 01 2019 (r345809) > > @@ -321,7 +321,7 @@ out: > > /* Signal the child process to go */ > > ASSERT_EQ(0, sem_post(sem)) << strerror(errno); > > > > - wait(&child_status); > > + ASSERT_LE(0, wait(&child_status)) << strerror(errno); > > Don=E2=80=99t you want ASSERT_GE here, since you=E2=80=99re testing that = wait succeeded? > -Enji Opposite operand order. I'm asserting that 0 is less than or equal to wait's return value. -Alan