From owner-freebsd-doc@FreeBSD.ORG Wed Nov 24 18:30:25 2004 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 141D016A4CE for ; Wed, 24 Nov 2004 18:30:25 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2D7A43D41 for ; Wed, 24 Nov 2004 18:30:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iAOIUO6x028436 for ; Wed, 24 Nov 2004 18:30:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iAOIUOFT028435; Wed, 24 Nov 2004 18:30:24 GMT (envelope-from gnats) Resent-Date: Wed, 24 Nov 2004 18:30:24 GMT Resent-Message-Id: <200411241830.iAOIUOFT028435@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-doc@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "freebsd@simplerezo.com" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB64D16A4CE for ; Wed, 24 Nov 2004 18:23:07 +0000 (GMT) Received: from xeon.ouestil.com (home.ouestil.com [81.56.27.190]) by mx1.FreeBSD.org (Postfix) with SMTP id 88BD943D41 for ; Wed, 24 Nov 2004 18:23:06 +0000 (GMT) (envelope-from root@xeon.ouestil.com) Received: (qmail 70685 invoked by uid 0); 24 Nov 2004 18:23:04 -0000 Message-Id: <20041124182304.70684.qmail@xeon.ouestil.com> Date: 24 Nov 2004 18:23:04 -0000 From: "freebsd@simplerezo.com" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: doc@FreeBSD.org Subject: docs/74328: [books/porters-handbook] Adding a call sample for pkg-install in Makefile X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "freebsd@simplerezo.com" List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2004 18:30:25 -0000 >Number: 74328 >Category: docs >Synopsis: [books/porters-handbook] Adding a call sample for pkg-install in Makefile >Confidential: no >Severity: non-critical >Priority: high >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Nov 24 18:30:24 GMT 2004 >Closed-Date: >Last-Modified: >Originator: freebsd@simplerezo.com >Release: FreeBSD 4.9-RELEASE-p12 i386 >Organization: SimpleRezo [http://www.simplerezo.com] >Environment: System: FreeBSD ---.simplerezo.com 4.9-RELEASE-p12 FreeBSD 4.9-RELEASE-p12 #0: Sun Nov 7 15:23:05 CET 2004 root@:/usr/obj/usr/src/sys/KERNEL i386 >Description: Because a lot of maintainer does not make a correct call to the pkg-install script in their Makefile, i think we should include a sample. Adding @PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PKGNAME} PRE-INSTALL is a mistake because with a WRKDIRPREFIX variable set, this would not work: pkg-install have to be replaced with the PKG-INSTALL variable substitution instead. >How-To-Repeat: >Fix: --- book.sgml.diff begins here --- --- book.sgml.orig Wed Nov 24 19:08:15 2004 +++ book.sgml Wed Nov 24 19:13:15 2004 @@ -5014,7 +5014,9 @@ This script is not run automatically if you install the port with make install. If you are depending on it being run, you will have to explicitly call it from your port's - Makefile. + Makefile, with a line like + @PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} + ${PKGNAME} PRE-INSTALL. --- book.sgml.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: