From nobody Fri Dec 9 14:11:07 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NTCcC4kzCz4jNl7; Fri, 9 Dec 2022 14:11:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NTCcC3WWlz46PP; Fri, 9 Dec 2022 14:11:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670595067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bBUqLq+zreWc9VATuYP+k+gN2K1spz1+oAF9FJUVWvg=; b=WknyRnr2les1kfJN4WpZo8aIBgqyUIffp/8bmFrhDooVJ8kEI3RINWoVtdRMY5Ii9JRXhD 2MVbaIYz2hP7XUnigR0mlKvPFE1pYKO90wZ1lJvl6+5u8Io4AMW4LXxpCGsmBVr4ONg0Y7 yFib0/OYh9UrpPz1GdoD5CotJKfXJRLtHKQbsC/FjphgXNZIX2JxPMoM/UVPLnDAXV8hSI e+GaZA58GY8vLhJ0kkG2vHTlVGz4cIPdWQOx6Xr6jr10V2M/gap5xFnYgbxVmZ97oSMY07 TS0QAxeiLqj1L65WweUrtKEnOyrtLXkPqbepNz+xk5JFgWffDL5sY29qYntTRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670595067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bBUqLq+zreWc9VATuYP+k+gN2K1spz1+oAF9FJUVWvg=; b=gkhkKG5ZxqpyAA4mypmzmBYnnEWsHS0/v3FPelPsKvYZx7CfEvl0Q5jfihwNEnEcxZF2jb JRxoIbVY5FHwNcnU0//X4KSS8lVd5i5uwb3wJJJNqWNjA/OnNA7ek0VCMnZGTcUJSPXgx5 Kt5q3KziZeCxaGWwJClsJQwu3FANb58dUer3CZamRzS67QWY56FPsnuh0NPaQfIzlpISWa agiL5/wew718UFrzn6/smq2pgxZ9W4wfk4RVM2RMYcwuGF4cfCmsIWjJ955P2Rov9TWQFZ Ife82EJPkL1jBtSfqp0lMzadw0M/0XyVQx2vst0tR4jh9yTi+XzR+OQrDwknsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670595067; a=rsa-sha256; cv=none; b=VKbaFb6wAil3zYaE8LxbfF6S8E6RPXy4b1S6rk8nA6dGlCB0RiLww/+GjMf6bBLbS2cdpO JTElnrFGknlVSIVhG3J1cao7MnP5gyXtSadgtm/UIYseuOtJFTDyHutabu02/FLCehgVGx emiLFLFVt5x/EzV7DTmpw97Fbdv5sdl/x0fIZgAvlYyozozhsEdlQ4XeNSEkqOHjsmZRMl dHa1pzsD7a+brYNRAzNhPQ/3Jaogdig1bI3x5EzmHsjSSS3WSS4hX0B3Kv2GcoYBCs2hKd eQ4YzOQE1LBaEFpmEL5xMO9/74/5OjZog/EUnhyzfEZLwfKyLYHJK4cMgUX7RQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NTCcC2XzXzfCc; Fri, 9 Dec 2022 14:11:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2B9EB7UR052887; Fri, 9 Dec 2022 14:11:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2B9EB7JW052886; Fri, 9 Dec 2022 14:11:07 GMT (envelope-from git) Date: Fri, 9 Dec 2022 14:11:07 GMT Message-Id: <202212091411.2B9EB7JW052886@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: 3deefb0d147d - main - heimdal: Properly ix bus fault when zero-length request received List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3deefb0d147d71047a13ec2328b1b721da2ce256 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=3deefb0d147d71047a13ec2328b1b721da2ce256 commit 3deefb0d147d71047a13ec2328b1b721da2ce256 Author: Cy Schubert AuthorDate: 2022-12-08 23:22:43 +0000 Commit: Cy Schubert CommitDate: 2022-12-09 14:09:54 +0000 heimdal: Properly ix bus fault when zero-length request received Zero length client requests result in a bus fault when attempting to free malloc()ed pointers within the requests softc. Return an error when the request is zero length. This properly fixes PR/268062 without regressions. PR: 268062 Reported by: Robert Morris MFC after: 3 days --- crypto/heimdal/kadmin/server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/heimdal/kadmin/server.c b/crypto/heimdal/kadmin/server.c index 19dfd89d521a..5e01277fe45b 100644 --- a/crypto/heimdal/kadmin/server.c +++ b/crypto/heimdal/kadmin/server.c @@ -473,6 +473,8 @@ v5_loop (krb5_context contextp, ret = krb5_read_priv_message(contextp, ac, &fd, &in); if(ret == HEIM_ERR_EOF) exit(0); + if (in.length == 0) + ret = HEIM_ERR_OPNOTSUPP; if(ret) krb5_err(contextp, 1, ret, "krb5_read_priv_message"); doing_useful_work = 1;