Date: Wed, 16 Aug 2006 14:10:02 -0700 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Erwin Lansing <erwin@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, FreeBSD Developers <developers@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.emacs.mk bsd.gnome.mk bsd.mail.mk bsd.openssl.mk bsd.port.mk bsd.port.subdir.mk bsd.python.mk bsd.ruby.mk bsd.scons.mk ports/Tools/scripts security-check.awk ports/databases/p5-DBD-Oracle Makefile ports/databases/p5-sqlrelay ... Message-ID: <44E389AA.3000003@FreeBSD.org> In-Reply-To: <200608041234.k74CYoc1076722@repoman.freebsd.org> References: <200608041234.k74CYoc1076722@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think the solution proposed in PR/100555 is overengineered. Why not to build temporary binary package as usually and then use chroot(8) (or -C flag for pkg_install) to install it into DESTDIR environment? This would be *much* simpler approach and it won't require modifying anything but bsd.port.mk. Putting additional load on port maintainers on keeping their ports DESTDIR-clean is too much for such a niche feature. -Maxim Erwin Lansing wrote: > erwin 2006-08-04 12:34:50 UTC > > FreeBSD ports repository > > Modified files: > Mk bsd.emacs.mk bsd.gnome.mk bsd.mail.mk > bsd.openssl.mk bsd.port.mk > bsd.port.subdir.mk bsd.python.mk > bsd.ruby.mk bsd.scons.mk > Tools/scripts security-check.awk > databases/p5-DBD-Oracle Makefile > databases/p5-sqlrelay Makefile > devel/p5-Devel-DProf Makefile > devel/p5-Glib2 Makefile > devel/p5-SDL Makefile > devel/plan9port Makefile > devel/subversion Makefile > graphics/ImageMagick Makefile > graphics/pgperl Makefile > graphics/tcm Makefile > japanese/p5-manual Makefile > japanese/perl5 Makefile > lang/erlang Makefile > lang/icc Makefile > lang/icc7 Makefile > lang/ifc Makefile > lang/ifc7 Makefile > lang/metaocaml Makefile > lang/perl5 Makefile > lang/perl5.8 Makefile > lang/pike72 Makefile > mail/qmailanalog Makefile > mail/zmailer Makefile > math/PDL Makefile > misc/ossp-uuid Makefile > net/globus4 Makefile > net/libpcap Makefile > net/mpich Makefile > net/rrdtool Makefile > net/rrdtool10 Makefile > net/spread Makefile > net/tcpdump Makefile > net-mgmt/flowd Makefile > net-mgmt/net-snmp Makefile > net-mgmt/nocol Makefile > palm/prc-tools Makefile > print/perlftlib Makefile > security/openssl Makefile > security/p5-openxpki Makefile > security/pam_krb5 Makefile > sysutils/heirloom Makefile > sysutils/pkg_install-devel pkg-deinstall pkg-install > sysutils/sge Makefile > textproc/p5-SGML-DTDParse Makefile > textproc/p5-XML-Handler-Dtd2DocBook Makefile > textproc/p5-XML-Handler-Dtd2Html Makefile > textproc/p5-XML-Handler-YAWriter Makefile > textproc/po4a Makefile > www/aolserver Makefile > www/apache13-modperl Makefile > www/libapreq2 Makefile > www/p5-HTTP-DAV Makefile > www/rt2 Makefile > www/slash Makefile > www/snownews Makefile > x11-toolkits/p5-qt Makefile > Log: > Add support for DESTDIR part I. > > This commit should largele be a NOOP as it only adds support > for DESTDIR undefined. This does allow us to start testing > ports with DESTDIR set, but this is as of yet not supported. > > Although this has been extensively tested on pointyhat, this > is a very intrusive change and some cases may have been > overlooked. Please contact Gabor and me if you find any. > > PR: 100555 > Submitted by: gabor > Sponsored by: Google Summer of Code 2006 > > Revision Changes Path > 1.58 +3 -3 ports/Mk/bsd.emacs.mk > 1.131 +8 -8 ports/Mk/bsd.gnome.mk > 1.2 +3 -3 ports/Mk/bsd.mail.mk > 1.31 +5 -5 ports/Mk/bsd.openssl.mk > 1.539 +386 -121 ports/Mk/bsd.port.mk > 1.65 +9 -9 ports/Mk/bsd.port.subdir.mk > 1.81 +2 -2 ports/Mk/bsd.python.mk > 1.153 +3 -3 ports/Mk/bsd.ruby.mk > 1.6 +2 -2 ports/Mk/bsd.scons.mk > 1.2 +40 -10 ports/Tools/scripts/security-check.awk > 1.8 +0 -1 ports/databases/p5-DBD-Oracle/Makefile > 1.18 +1 -1 ports/databases/p5-sqlrelay/Makefile > 1.19 +0 -1 ports/devel/p5-Devel-DProf/Makefile > 1.21 +1 -1 ports/devel/p5-Glib2/Makefile > 1.17 +1 -1 ports/devel/p5-SDL/Makefile > 1.16 +1 -1 ports/devel/plan9port/Makefile > 1.104 +1 -1 ports/devel/subversion/Makefile > 1.223 +1 -1 ports/graphics/ImageMagick/Makefile > 1.29 +1 -1 ports/graphics/pgperl/Makefile > 1.13 +1 -1 ports/graphics/tcm/Makefile > 1.13 +1 -1 ports/japanese/p5-manual/Makefile > 1.40 +1 -1 ports/japanese/perl5/Makefile > 1.91 +4 -4 ports/lang/erlang/Makefile > 1.92 +1 -1 ports/lang/icc/Makefile > 1.71 +1 -1 ports/lang/icc7/Makefile > 1.46 +1 -1 ports/lang/ifc/Makefile > 1.31 +1 -1 ports/lang/ifc7/Makefile > 1.7 +1 -1 ports/lang/metaocaml/Makefile > 1.89 +1 -1 ports/lang/perl5.8/Makefile > 1.70 +1 -1 ports/lang/perl5/Makefile > 1.34 +1 -1 ports/lang/pike72/Makefile > 1.24 +1 -1 ports/mail/qmailanalog/Makefile > 1.20 +1 -1 ports/mail/zmailer/Makefile > 1.44 +1 -1 ports/math/PDL/Makefile > 1.23 +1 -1 ports/misc/ossp-uuid/Makefile > 1.9 +1 -1 ports/net-mgmt/flowd/Makefile > 1.134 +1 -1 ports/net-mgmt/net-snmp/Makefile > 1.13 +1 -1 ports/net-mgmt/nocol/Makefile > 1.8 +1 -1 ports/net/globus4/Makefile > 1.8 +1 -1 ports/net/libpcap/Makefile > 1.44 +1 -1 ports/net/mpich/Makefile > 1.58 +1 -1 ports/net/rrdtool/Makefile > 1.55 +1 -1 ports/net/rrdtool10/Makefile > 1.19 +1 -1 ports/net/spread/Makefile > 1.19 +1 -1 ports/net/tcpdump/Makefile > 1.50 +1 -1 ports/palm/prc-tools/Makefile > 1.22 +1 -1 ports/print/perlftlib/Makefile > 1.117 +2 -2 ports/security/openssl/Makefile > 1.4 +2 -3 ports/security/p5-openxpki/Makefile > 1.23 +2 -2 ports/security/pam_krb5/Makefile > 1.7 +1 -1 ports/sysutils/heirloom/Makefile > 1.3 +3 -3 ports/sysutils/pkg_install-devel/pkg-deinstall > 1.3 +3 -3 ports/sysutils/pkg_install-devel/pkg-install > 1.19 +1 -1 ports/sysutils/sge/Makefile > 1.2 +0 -1 ports/textproc/p5-SGML-DTDParse/Makefile > 1.2 +0 -1 ports/textproc/p5-XML-Handler-Dtd2DocBook/Makefile > 1.2 +0 -1 ports/textproc/p5-XML-Handler-Dtd2Html/Makefile > 1.5 +0 -1 ports/textproc/p5-XML-Handler-YAWriter/Makefile > 1.2 +1 -1 ports/textproc/po4a/Makefile > 1.22 +2 -2 ports/www/aolserver/Makefile > 1.17 +1 -1 ports/www/apache13-modperl/Makefile > 1.18 +1 -1 ports/www/libapreq2/Makefile > 1.5 +0 -1 ports/www/p5-HTTP-DAV/Makefile > 1.24 +1 -1 ports/www/rt2/Makefile > 1.15 +1 -1 ports/www/slash/Makefile > 1.24 +1 -1 ports/www/snownews/Makefile > 1.8 +1 -1 ports/x11-toolkits/p5-qt/Makefile > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44E389AA.3000003>