From owner-freebsd-current@FreeBSD.ORG Sun Oct 26 23:14:57 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 835F116A4B3 for ; Sun, 26 Oct 2003 23:14:57 -0800 (PST) Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CCF443FA3 for ; Sun, 26 Oct 2003 23:14:56 -0800 (PST) (envelope-from ken@panzer.kdm.org) Received: from panzer.kdm.org (localhost [127.0.0.1]) by panzer.kdm.org (8.12.9/8.12.5) with ESMTP id h9R7Er64043693 for ; Mon, 27 Oct 2003 00:14:53 -0700 (MST) (envelope-from ken@panzer.kdm.org) Received: (from ken@localhost) by panzer.kdm.org (8.12.9/8.12.5/Submit) id h9R7Er0w043692 for current@FreeBSD.org; Mon, 27 Oct 2003 00:14:53 -0700 (MST) (envelope-from ken) Date: Mon, 27 Oct 2003 00:14:53 -0700 From: "Kenneth D. Merry" To: current@FreeBSD.org Message-ID: <20031027071453.GA43658@panzer.kdm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: HEADS UP: CAM error recovery change X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2003 07:14:57 -0000 I checked in a change to the CAM error recovery code that will hopefully have a positive effect on systems with CDROM drives that were taking a while to probe. Anyway, try this out and let me know if there are any regressions. Thanks, Ken ----- Forwarded message from "Kenneth D. Merry" ----- From: "Kenneth D. Merry" Date: Sun, 26 Oct 2003 22:15:55 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/cam cam_periph.c src/sys/cam/scsi scsi_cd.c ken 2003/10/26 22:15:55 PST FreeBSD src repository Modified files: sys/cam cam_periph.c sys/cam/scsi scsi_cd.c Log: In camperiphdone(), make sure we check for fatal errors and bail out instead of retrying them blindly. This should fix some of the problems people have been having with cdrom drives taking a long time to probe. This should also eliminate the need for the initial TUR in cdsize(). cam_periph.c: Don't keep retrying if the error we get back is a fatal error. This should help us detect the transition from "Logical unit not ready, cause not reportable" to "Medium not present" in the "TUR many" handler. (The TUR many handler gets triggered for Logical unit not ready, cause not reportable errors.) scsi_cd.c: Remove the initial test unit ready in cdsize(). Hopefully it isn't necessary after the above change. Submitted by: gibbs (mostly) Tested by: peter MFC After: 2 weeks Revision Changes Path 1.55 +17 -2 src/sys/cam/cam_periph.c 1.88 +0 -14 src/sys/cam/scsi/scsi_cd.c ----- End forwarded message ----- -- Kenneth Merry ken@kdm.org