From owner-freebsd-net  Wed Nov 14 13:15:15 2001
Delivered-To: freebsd-net@freebsd.org
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by hub.freebsd.org (Postfix) with ESMTP id 6BAFB37B418
	for <freebsd-net@FreeBSD.ORG>; Wed, 14 Nov 2001 13:15:09 -0800 (PST)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id NAA67647;
	Wed, 14 Nov 2001 13:04:52 -0800 (PST)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.11.6/8.11.6) id fAEL4qd63013;
	Wed, 14 Nov 2001 13:04:52 -0800 (PST)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200111142104.fAEL4qd63013@arch20m.dellroad.org>
Subject: Re: Mpd with a large number, 200+ , of bundles
In-Reply-To: <3BF299DB.2080607@ii.uib.no> "from Trond Davidsen at Nov 14, 2001
 05:20:43 pm"
To: Trond Davidsen <trond.davidsen@ii.uib.no>
Date: Wed, 14 Nov 2001 13:04:52 -0800 (PST)
Cc: freebsd-net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL82 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

Trond Davidsen writes:
> > If you can get mpd into a state where "kill -9" doesn't kill it,
> > then that seems like a kernel bug to me, and so we should probably
> > hone in on that first..  maybe we can come up with a simple test
> > case, e.g. using the event library debug output, write a program
> > that opens the same number of file descriptors, pipes, etc. and
> > registers the same event handlers, etc..
> 
> I think I've got a solution, insert '#define FD_SETSIZE 2048' at the top 
> of 'event.c', over '#include <sys/types.h>'.  This seems to solve the 
> problem for me, for now :)

Ah, good sleuthing!

You might also want to apply the patch below as a safety measure.

Thanks,
-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

Index: event.c
===================================================================
RCS file: /home/cvs/archie/mpd/src/event.c,v
retrieving revision 1.2
diff -u -r1.2 event.c
--- event.c	2001/06/16 05:07:55	1.2
+++ event.c	2001/11/14 21:04:24
@@ -444,6 +444,8 @@
     case EVENT_READ:
     case EVENT_WRITE:
     case EVENT_EXCEPTION:
+      bad = (val < 0) || val >= FD_SETSIZE;
+      break;
     case EVENT_TIMEOUT:
       bad = (val < 0);
       break;

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message