Date: Thu, 13 Sep 2012 11:30:08 GMT From: Vitaly Magerya <vmagerya@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/171575: [patch] sysutils/uhidd: make it work with clang (encoding-related) Message-ID: <201209131130.q8DBU8If021179@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/171575; it has been noted by GNATS. From: Vitaly Magerya <vmagerya@gmail.com> To: Jan Beich <jbeich@tormail.org> Cc: bug-followup@FreeBSD.org Subject: Re: ports/171575: [patch] sysutils/uhidd: make it work with clang (encoding-related) Date: Thu, 13 Sep 2012 14:26:31 +0300 Jan Beich wrote: > What if there's a KPI change? > [...] > +.if !empty(CC:M*clang*) > +CFLAGS+= -Wno-error=invalid-source-encoding > +.endif The reason I did not propose this is because /usr/bin/cc will become clang some time soon, so that kind of detection will not work (and gcc does not recognize that option, so one can't use it unconditionally). If preserving -Werror is desired, the first patch in the PR above can be used (I'm afraid it's formatting is broken, but the idea should be clear).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209131130.q8DBU8If021179>