From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Sep 13 11:30:08 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85FE5106564A for ; Thu, 13 Sep 2012 11:30:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 699E58FC0C for ; Thu, 13 Sep 2012 11:30:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8DBU890021195 for ; Thu, 13 Sep 2012 11:30:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8DBU8If021179; Thu, 13 Sep 2012 11:30:08 GMT (envelope-from gnats) Date: Thu, 13 Sep 2012 11:30:08 GMT Message-Id: <201209131130.q8DBU8If021179@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Vitaly Magerya Cc: Subject: Re: ports/171575: [patch] sysutils/uhidd: make it work with clang (encoding-related) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Vitaly Magerya List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2012 11:30:08 -0000 The following reply was made to PR ports/171575; it has been noted by GNATS. From: Vitaly Magerya To: Jan Beich Cc: bug-followup@FreeBSD.org Subject: Re: ports/171575: [patch] sysutils/uhidd: make it work with clang (encoding-related) Date: Thu, 13 Sep 2012 14:26:31 +0300 Jan Beich wrote: > What if there's a KPI change? > [...] > +.if !empty(CC:M*clang*) > +CFLAGS+= -Wno-error=invalid-source-encoding > +.endif The reason I did not propose this is because /usr/bin/cc will become clang some time soon, so that kind of detection will not work (and gcc does not recognize that option, so one can't use it unconditionally). If preserving -Werror is desired, the first patch in the PR above can be used (I'm afraid it's formatting is broken, but the idea should be clear).