From owner-cvs-all@FreeBSD.ORG Wed Apr 14 08:03:23 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5212016A4CE; Wed, 14 Apr 2004 08:03:23 -0700 (PDT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1F6D43D2D; Wed, 14 Apr 2004 08:03:22 -0700 (PDT) (envelope-from scottl@freebsd.org) Received: from freebsd.org (junior-wifi.samsco.home [192.168.0.11]) by pooker.samsco.org (8.12.10/8.12.10) with ESMTP id i3EF5Qc8096539; Wed, 14 Apr 2004 09:05:26 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <407D52B7.80507@freebsd.org> Date: Wed, 14 Apr 2004 09:03:19 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brian Feldman References: <200404141457.i3EEvo7h069562@repoman.freebsd.org> In-Reply-To: <200404141457.i3EEvo7h069562@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/sound/isa ad1816.c ess.c mss.c sb16.c sb8.c sbc.c src/sys/dev/sound/pci cmi.c csa.c csapcm.c ds1.c emu10k1.c ich.c t4dwave.c src/sys/dev/sound/pcm sound.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2004 15:03:23 -0000 Brian Feldman wrote: > green 2004/04/14 07:57:50 PDT > > FreeBSD src repository > > Modified files: > sys/dev/sound/isa ad1816.c ess.c mss.c sb16.c sb8.c sbc.c > sys/dev/sound/pci cmi.c csa.c csapcm.c ds1.c emu10k1.c > ich.c t4dwave.c > sys/dev/sound/pcm sound.h > Log: > The newpcm headers currently #define away INTR_MPSAFE and INTR_TYPE_AV > because they bogusly check for defined(INTR_MPSAFE) -- something which > never was a #define. Correct the definitions. > > This make INTR_TYPE_AV finally get used instead of the lower-priority > INTR_TYPE_TTY, so it's quite possible some improvement will be had > on sound driver performance. It would also make all the drivers > marked INTR_MPSAFE actually run without Giant (which does seem to > work for me), but: > INTR_MPSAFE HAS BEEN REMOVED FROM EVERY SOUND DRIVER! > It needs to be re-added on a case-by-case basis since there is no one > who will vouch for which sound drivers, if any, willy actually operate > correctly without Giant, since there hasn't been testing because of > this bug disabling INTR_MPSAFE. > Ha! you touched it last! Neener neener neener! Scott