From owner-freebsd-fs Fri Nov 22 16:50:14 2002 Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D15D637B401 for ; Fri, 22 Nov 2002 16:50:13 -0800 (PST) Received: from sccrmhc02.attbi.com (sccrmhc02.attbi.com [204.127.202.62]) by mx1.FreeBSD.org (Postfix) with ESMTP id 469CF43EAF for ; Fri, 22 Nov 2002 16:50:13 -0800 (PST) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by sccrmhc02.attbi.com (sccrmhc02) with ESMTP id <2002112300500100200t4vqqe>; Sat, 23 Nov 2002 00:50:02 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA17009; Fri, 22 Nov 2002 16:48:04 -0800 (PST) Date: Fri, 22 Nov 2002 16:48:03 -0800 (PST) From: Julian Elischer To: fs@freebsd.org Cc: mckusick@mckusick.com Subject: ufs types Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org We had a system on site today that fell over every time re tried to boot it. Causing delays in probably many millions of dollars of transfers. The reason was a currupt word in the cylinder group summary information. a word had been trashed becoming -ve, and fsck didn't check against -ve numbers in that (a rotor value). Noticing that most fields are not checked against being -ve in fsck we started looking at fixing it.. until we realised that the far quicker answer was to define them to be unsigned in ufs.h and just fix the compile errors.. The values are usually checked for reasonable +ve values. Does anyone have a reason why we should not do this in FreeBSD? (fix the superblock and cg summary blocks to have mostly unsigned values..) julian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message