From owner-svn-ports-all@FreeBSD.ORG  Tue Dec 10 17:49:02 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9E7D9DE9;
 Tue, 10 Dec 2013 17:49:02 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 by mx1.freebsd.org (Postfix) with ESMTP id 760C410AB;
 Tue, 10 Dec 2013 17:49:02 +0000 (UTC)
Received: from tuna.dhcp.nue.suse.com (nat.nue.novell.com [195.135.221.2])
 by ainaz.pair.com (Postfix) with ESMTPSA id 4923B3F410;
 Tue, 10 Dec 2013 12:48:53 -0500 (EST)
Date: Tue, 10 Dec 2013 18:48:51 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Kozlov Sergey <kozlov.sergey.404@gmail.com>
Subject: Re: svn commit: r335189 - in head/print/pdftk: . files
In-Reply-To: <52A7471E.6080109@gmail.com>
Message-ID: <alpine.LNX.2.00.1312101845340.2197@tuna.site>
References: <201311291548.rATFm8g7098382@svn.freebsd.org>
 <alpine.LNX.2.00.1312012257230.2185@tuna.site>
 <C89CD972357B819FE03015D6@atuin.in.mat.cc> <529C7599.1050509@gmail.com>
 <alpine.LNX.2.00.1312082235050.2197@tuna.site> <52A7471E.6080109@gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: Mathieu Arnold <mat@FreeBSD.org>, Greg Larkin <glarkin@FreeBSD.org>,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2013 17:49:02 -0000

On Tue, 10 Dec 2013, Kozlov Sergey wrote:
> Yes, that's correct. I think the right solution is to add a check if 
> gcj is present and give an IGNORE with suggestion to rebuild gcc.

Agreed.  If gcj is not present despite that dependency, that's a
good idea.  Would you like to propose a patch?

>>    LIB_DEPENDS=	libgcj.so:${PORTSDIR}/lang/gcc${CSUFF} \
>> 		libstdc++.so:${PORTSDIR}/lang/gcc${CSUFF} \
>> 		libgcc_s.so:${PORTSDIR}/lang/gcc${CSUFF}
>> 
>> If you insist on libgcj.so, I can accept that, but then let's drop
>> the other two least.  This is definitely covered by USE_GCC=yes.
> USE_GCC doesn't add anything to RUN_DEPENDS.

Sure it does:

  .if defined(_GCC_PORT_DEPENDS)
  BUILD_DEPENDS+= ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT}
  . if ${_USE_GCC} != 3.4
  RUN_DEPENDS+=   ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT}
  # Later GCC ports already depend on binutils; make sure whatever we
  # build leverages this as well.
  USE_BINUTILS=   yes
  . endif
  .endif

> On 08.12.2013 23:39, Gerald Pfeifer wrote:
>> Can I go ahead and just make that
>> 
>>    LIB_DEPENDS=    libgcj.so:${PORTSDIR}/lang/gcc${CSUFF}
>>    BUILD_DEPENDS=  gcj${CSUFF}:${PORTSDIR}/lang/gcc${CSUFF}
> Generally speaking, I think that's ok but we should really hear the 
> opinion of port's maintainer.

Let's see what he thinks.  And I am queuing this up on my side to 
keep an eye on it. 

Gerald