From owner-freebsd-net@freebsd.org Tue Sep 17 18:47:22 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3914812BC47 for ; Tue, 17 Sep 2019 18:47:22 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XsY51Tlgz4Xw8 for ; Tue, 17 Sep 2019 18:47:21 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd2c.google.com with SMTP id r26so10058043ioh.8 for ; Tue, 17 Sep 2019 11:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ehebyxQbSMphs+8Ux6qXwme/XLGWRn4dhiwjyevXlUY=; b=DAhKksYReUbnvELrPd/cDlrcHvd7xuGEn2a+U0YMZWM2627HEIdzqvD+k+6gWHpgsK 6rT3hjrWectjxOHxEdcybOgliGOBB2M5eUK+FXDSWUuJoEc5i07tn4d8sm4OJ21jUMQN +QxOuJEi/1DFlMwMeG83MnSPCIpm88zlJmMH3aCiwYh5tDCsaxjUNqsfGHhWEIHAZWEI VdAtliLCBrrKgBsJVO5Agy3xzPpcj6SllexfBoxcC6TWxaNkuGKSkG2jpJR37n2e2eCq T2aiKZ4UiD5SR8xcRwKrmGiFxYpgIxXuZ+FPh+N9Ziwn70cfNmrrlV/dOCXBgkLO3WwN Eiww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehebyxQbSMphs+8Ux6qXwme/XLGWRn4dhiwjyevXlUY=; b=o0h8boz3lbmSX9mB8mQ+gE8hJFAdWIU36wjfzXZFMUJwo7LoeTGp51xQ3+6TEdEOEB 5/cTwOmisljQIfKWftLVHvabOabApb1oLo5fVi3KUZmV3dcpXs4deSPnjkCWDdc9ZLRq RU3SaLNfcmekovgnGnrQEmPCSoom0iTyz7mnfBpQ/W/47R2ZquYgy6h8OcU6JVAMmbuc ytxuak2H3XehKaegj9XDPX3hv9c7RWyUhN6yC2sZYVOA1UzBS1u/Pym2MbbWrF2vQZnv JS7KBxRIz4/d8hBcgsKHZuxwiG6VR2E7WxH3+3PKnKKMLgIv7mHnxHICG8TPSEAipLHX Tu8Q== X-Gm-Message-State: APjAAAW7q5azBOu0WdlH02rCYs7zFXmopT6+kFsbBi13tj43vIJPrYAp jt6aUITE8T3p5iK7tDSMtWj69Bdlv4wf2+Jrk9U= X-Google-Smtp-Source: APXvYqz3XtOle6ZixSpAVIaFC+aYNTPsadNo1vq9KINIi0xKMdVWLtqUTbKryU3Y/LRDyyhD0fHsE+pKjcYVXRRWQzg= X-Received: by 2002:a6b:2c8d:: with SMTP id s135mr252210ios.98.1568746040214; Tue, 17 Sep 2019 11:47:20 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> In-Reply-To: From: vm finance Date: Tue, 17 Sep 2019 18:47:08 +0000 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46XsY51Tlgz4Xw8 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=DAhKksYR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d2c as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-5.37), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[c.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; SUBJECT_ENDS_QUESTION(1.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 18:47:22 -0000 Got it - thank you! btw, I tried to build the patch but its giving an error. Following is SVN info + make error mesg. Please let me know what am I missing here? Thanks! #svnlite revision Path: . Working Copy Root Path: /usr/src URL: svn://svn.freebsd.org/base/head Relative URL: ^/head Repository Root: svn://svn.freebsd.org/base Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f Revision: 352436 Node Kind: directory Schedule: normal Last Changed Author: jah Last Changed Rev: 352434 Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) root@osboxes:/usr/src # -------------------------------------------- snip ---------------------------- ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS ===> sys (cleandir) rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_kern_tls.h rm: x86: is a directory *** Error code 1 Stop. make[3]: stopped in /usr/src/sys *** Error code 1 Stop. make[2]: stopped in /usr/src *** Error code 1 Stop. make[1]: stopped in /usr/src *** Error code 1 Stop. make: stopped in /usr/src On Tue, Sep 17, 2019 at 6:41 PM vm finance wrote: > Got it - thank you! > > btw, I tried to build the patch but its giving an error. Following is SVN > info + make error mesg. > I have also attached the entire build log...snippet is below > > Please let me know what am I missing here? > > Thanks! > > #svnlite revision > Path: . > Working Copy Root Path: /usr/src > URL: svn://svn.freebsd.org/base/head > Relative URL: ^/head > Repository Root: svn://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 352436 > Node Kind: directory > Schedule: normal > Last Changed Author: jah > Last Changed Rev: 352434 > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > root@osboxes:/usr/src # > > -------------------------------------------- snip > ---------------------------- > > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo > bcache.llo interp_simple.llo zfs_cmd.llo > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > ===> sys (cleandir) > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o > rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > opt_kern_tls.h > rm: x86: is a directory > *** Error code 1 > > Stop. > make[3]: stopped in /usr/src/sys > *** Error code 1 > > Stop. > make[2]: stopped in /usr/src > *** Error code 1 > > Stop. > make[1]: stopped in /usr/src > *** Error code 1 > > Stop. > make: stopped in /usr/src > > > On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart wrote: > >> Pacing is provided by tcp_hpts.c. The current linux patches do not have >> to have fq.. they built an alternate means of doing pacing into bbr. >> >> In either case our testing has shown that our pacing is more accurate than >> either fq or the internal pacer :) >> >> R >> >> > On Sep 17, 2019, at 11:05 AM, vm finance wrote: >> > >> > Thanks Randall. >> > I was able to apply the patch - now rebuilding the kernel. Would update >> on how it goes. >> > >> > BTW, is there any description on how lack of tc_fq under FreeBSD is >> compensated here? >> > The original BBR patches on Linux show that as a must-have? Is that >> functionality implemented via tcp_ratelimit.[ch]? >> > >> > Any pointers to existing presentations/discussions highly appreciated? >> > >> > Thanks a lot. >> > >> > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart >> wrote: >> > You should be able to compile it against the current head. I re-doing >> that now (had an >> > issue with my machine and had to roll it back to a backup). >> > >> > When I put the patch up on Sept 10th it complied with and without BBR >> on whatever >> > was that rev.. >> > >> > Looking in the commit logs that would have been around 352191 >> > >> > Hope that helps >> > >> > R >> > >> > > On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> > > >> > > Hi Randall, >> > > >> > > Thanks for releasing BBR patch: >> > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> > > >> > > Could you please let me know what SVN/GIT label tag this is based on? >> I would like to patch and experiment with it. I couldn't find this info in >> the released patch. >> > > >> > > Thanks a lot! >> > > >> > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> > > rrs@ has just posted the BBR patch to phabricator: >> > > >> > > https://reviews.freebsd.org/D21582 >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >>