From owner-cvs-all Sun Jan 21 18: 4: 5 2001 Delivered-To: cvs-all@freebsd.org Received: from mobile.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id A021B37B699; Sun, 21 Jan 2001 18:03:40 -0800 (PST) Received: from netplex.com.au (localhost [127.0.0.1]) by mobile.wemm.org (8.11.1/8.11.1) with ESMTP id f0M23ek09758; Sun, 21 Jan 2001 18:03:40 -0800 (PST) (envelope-from peter@netplex.com.au) Message-Id: <200101220203.f0M23ek09758@mobile.wemm.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: John Baldwin Cc: Julian Elischer , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jason Evans Subject: Re: cvs commit: src/sys/alpha/include mutex.h src/sys/i386/inclu In-Reply-To: Date: Sun, 21 Jan 2001 18:03:40 -0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG John Baldwin wrote: > On 21-Jan-01 Julian Elischer wrote: > > What is the reasoning? (not complaining, just curious) > > Inlining all of these can bloat the kernel unfortunately. Jason estimated > 650kb of extra code in a non-debug kernel from this when we hit 5.0. There is a crossover point between cost of burning up L1 and L2 cache compared to the cost of a function call. Inlining usually increases the speed of microbenchmarks that are focussed on one particular subsystem, but at the overall expense of the rest of the system as there is now less cache to go around. This shows up in things like having microbenchmarks going slightly faster but slowing down things like 'make world' etc. There are lots of pros and cons each way. But right now with all this inlined it is quite difficult to debug as there is no stack frame. When some random blob of code faults it can be quite a mystery to figure out where the hell you are in ddb unless you have a very good recognition of what all the inline generated code looks like. This may not be the final form, but at least it gives us less headaches trying to do debugging. And debugging is something that we need no extra pain over right now. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message