From owner-freebsd-arch@FreeBSD.ORG  Mon Mar  1 10:58:08 2004
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 83F8E16A4CE
	for <arch@freebsd.org>; Mon,  1 Mar 2004 10:58:08 -0800 (PST)
Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ECB7043D3F
	for <arch@freebsd.org>; Mon,  1 Mar 2004 10:58:07 -0800 (PST)
	(envelope-from marius@newtrinity.zeist.de)
Received: from newtrinity.zeist.de (localhost [127.0.0.1])
	i21Iw7a7063565;	Mon, 1 Mar 2004 19:58:07 +0100 (CET)
	(envelope-from marius@newtrinity.zeist.de)
Received: (from marius@localhost)
	by newtrinity.zeist.de (8.12.10/8.12.10/Submit) id i21Iw1c8063564;
	Mon, 1 Mar 2004 19:58:01 +0100 (CET)
	(envelope-from marius)
Date: Mon, 1 Mar 2004 19:58:01 +0100
From: Marius Strobl <marius@alchemy.franken.de>
To: Alexander Leidinger <Alexander@Leidinger.net>
Message-ID: <20040301195801.Q38442@newtrinity.zeist.de>
References: <20040229182209.7d1cdd12@Magellan.Leidinger.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20040229182209.7d1cdd12@Magellan.Leidinger.net>;
	from Alexander@Leidinger.net on Sun, Feb 29, 2004 at 06:22:09PM +0100
X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.24.0.5; VDF 6.24.0.29
	     (host: newtrinity.zeist.de)
cc: arch@freebsd.org
cc: Garance A Drosihn <drosih@rpi.edu>
Subject: Re: updated Intel C compiler patch-set (kernel code and build
	infrastructure)
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Mar 2004 18:58:08 -0000

On Sun, Feb 29, 2004 at 06:22:09PM +0100, Alexander Leidinger wrote:
> Hi,
> 
> I've updated the icc patch-set at
> http://www.leidinger.net/FreeBSD/current-patches/ relative to -current
> from Feb 26.
> 

Like noted in a private mail to you earlier I wouldn't use both
__ICC (which corresponds to "__INTEL_COMPILER && __i386__") and
__INTEL_COMPILER in preprocessor directives but stick with
__INTEL_COMPILER only. In all the places where the patch uses
__ICC it's either implicitly clear that the code is i386-specific
(because of the file location etc.) or isn't relevant (because
ECC, which AFAIK is the sole other Intel Compiler also defining
__INTEL_COMPILER, understands the same code etc.).
I think in the long term using both, __ICC and __INTEL_COMPILER,
will just cause confusion and the current scheme won't be adhered.