From owner-cvs-all@FreeBSD.ORG  Thu Dec  8 04:49:19 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D1BAF16A41F;
	Thu,  8 Dec 2005 04:49:19 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4469543D4C;
	Thu,  8 Dec 2005 04:49:16 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jB84mt6F052554;
	Thu, 8 Dec 2005 04:48:57 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4397BB3B.2010008@freebsd.org>
Date: Thu, 08 Dec 2005 12:48:59 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20050928
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Daniel Eischen <deischen@freebsd.org>
References: <Pine.GSO.4.43.0512072210410.27928-100000@sea.ntplx.net>
In-Reply-To: <Pine.GSO.4.43.0512072210410.27928-100000@sea.ntplx.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Scott Long <scottl@samsco.org>, src-committers@freebsd.org,
	Doug Ambrisko <ambrisko@ambrisko.com>,
	John Baldwin <jhb@freebsd.org>, cvs-src@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/sys signal.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Dec 2005 04:49:20 -0000

Daniel Eischen wrote:
> I was going to do it in libc so it doesn't have to be done by each
> thread library.
> 
> But there are still aio_* syscalls that haven't been changed to have
> compat syscalls.  You did aio_read, aio_write, and lio_listion, but
> not aio_error, aio_return, aio_suspend, aio_cancel, and aio_waitcomplete.
> I think these really need compat syscalls due to the different layout of
> struct sigevent (because it affects layout of struct aiocb).
> 
The aio_error, aio_return and other syscalls don't access sigevent,
they all access kernel private data of aiocb, I left old sigevent space 
there, but will not be used by new syscalls, the new sigevent is
appended at end of aiocb, offset of kernel private data area is not changed.

> I don't think Library-level shims aren't going to help in the case of
> statically built binaries.
>