From owner-cvs-all Tue Jun 15 15:47:18 1999 Delivered-To: cvs-all@freebsd.org Received: from panzer.plutotech.com (panzer.plutotech.com [206.168.67.125]) by hub.freebsd.org (Postfix) with ESMTP id 44E21156A0; Tue, 15 Jun 1999 15:47:10 -0700 (PDT) (envelope-from ken@panzer.plutotech.com) Received: (from ken@localhost) by panzer.plutotech.com (8.9.3/8.8.5) id QAA76772; Tue, 15 Jun 1999 16:47:10 -0600 (MDT) Message-Id: <199906152247.QAA76772@panzer.plutotech.com> Subject: Re: cvs commit: src/lib/libcam camlib.c In-Reply-To: <199906152003.NAA34313@freefall.freebsd.org> from Mike Pritchard at "Jun 15, 1999 01:03:03 pm" To: mpp@FreeBSD.org (Mike Pritchard) Date: Tue, 15 Jun 1999 16:47:10 -0600 (MDT) Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org From: Kenneth Merry X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Mike Pritchard wrote... > mpp 1999/06/15 13:03:03 PDT > > Modified files: > lib/libcam camlib.c > Log: > cam_get_device() was returning 0 on failure, and 1 on success, while > camcontrol(8) and the documentation in camlib.c and cam(3) all expect > -1 on failure and 0 on success. Updated camlib.c to return the values > specified by the documentation. > > PR: 12023 This looks like the correct fix, but I really wish you had asked me about this. In the future, when making code modifications to something I've written, please ask me first! Ken -- Kenneth Merry ken@plutotech.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message