From owner-svn-src-head@FreeBSD.ORG Sat Jan 21 00:23:14 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD207106567A; Sat, 21 Jan 2012 00:23:14 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 92CA48FC26; Sat, 21 Jan 2012 00:23:13 +0000 (UTC) Received: by lahe6 with SMTP id e6so860543lah.13 for ; Fri, 20 Jan 2012 16:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=7683+zfbBT6S5SuU10UXZFYlDBCRUQPsXvbXNyjaWmU=; b=N6L2HBlvD9bB6qwNMdtcerUTGMafWVvgz1bBN+q2Xdivik8AO69L8T81+FXlesnUUk gK3X8kwTqfTfesWsGLC0xXr0QOsUaho3vT5BBuUL7fQoGC+lB3gpqCKH6zx+mRvrakAP qH2KMT7isGxoXDCrAXDvzm9H2DHR+01IxM7/o= Received: by 10.152.135.105 with SMTP id pr9mr15721754lab.19.1327105392211; Fri, 20 Jan 2012 16:23:12 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.196 with HTTP; Fri, 20 Jan 2012 16:22:41 -0800 (PST) In-Reply-To: <20120121103348.Q1254@besplex.bde.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120121103348.Q1254@besplex.bde.org> From: Eitan Adler Date: Fri, 20 Jan 2012 19:22:41 -0500 X-Google-Sender-Auth: Ik7DMNqXSSbUlp-AyDpPeVVE5ys Message-ID: To: Bruce Evans Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato , src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2012 00:23:14 -0000 On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans wrote: > I agree. =C2=A0Never fix vendor code. =C2=A0Especially style bugs in it. = =C2=A0Not all > vendor code is in contrib. I'm sure this is a silly question, but why isn't this utility in a contrib/ folder? > In fact, it seems that there there was a very large amount of unused code= , > and this commit only removes the tip of it. =C2=A0There is lots more code= to > initialize msrargs.data in the above, but now msrargs.data is unised too. > This is apparently too complicated for the compiler to see that it is > unused: I had more patches which this conversation is making me hold back on: this code is contributed it doesn't fall under my goal of making the world buildable with gcc46. [snip other fixes to the api] > I don't understand this code well enough to fix it. =C2=A0Fixing it requi= res > understanding whether the unused variable was unused because of another > bug. =C2=A0Another bug seems likely here, since there is so much dead cod= e. > Or maybe I'm just confused, and the dead code is actually undead. =C2=A0I= t > is complicated enough for this to be unclear. I did not just rely on the compiler - I went through the code manually to ensure it was correct. --=20 Eitan Adler Ports committer X11, Bugbusting teams