From owner-freebsd-ports@FreeBSD.ORG  Tue May 11 09:27:10 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3E54A106566C
	for <freebsd-ports@freebsd.org>; Tue, 11 May 2010 09:27:10 +0000 (UTC)
	(envelope-from ml@netfence.it)
Received: from cp-out9.libero.it (cp-out9.libero.it [212.52.84.109])
	by mx1.freebsd.org (Postfix) with ESMTP id CB62D8FC1B
	for <freebsd-ports@freebsd.org>; Tue, 11 May 2010 09:27:09 +0000 (UTC)
Received: from soth.ventu (151.51.8.163) by cp-out9.libero.it (8.5.107)
	id 4BDFD35F0126C7F9; Tue, 11 May 2010 11:26:56 +0200
Received: from alamar.ventu (alamar.ventu [10.1.2.18])
	by soth.ventu (8.14.4/8.14.3) with ESMTP id o4B9Qocm072488;
	Tue, 11 May 2010 11:26:50 +0200 (CEST) (envelope-from ml@netfence.it)
Message-ID: <4BE922DA.8070407@netfence.it>
Date: Tue, 11 May 2010 11:26:50 +0200
From: Andrea Venturoli <ml@netfence.it>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; it-IT;
	rv:1.9.1.9) Gecko/20100402 Thunderbird/3.0.4
MIME-Version: 1.0
To: Alex Keda <admin@lissyara.su>, freebsd-ports@freebsd.org
References: <4BE020E3.9080803@netfence.it> <4BE15A97.30402@lissyara.su>
	<4BE15FAC.4090107@netfence.it> <4BE16F81.6050002@lissyara.su>
In-Reply-To: <4BE16F81.6050002@lissyara.su>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: 
Subject: Re: php52 and Horde
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 May 2010 09:27:10 -0000

On 05/05/10 15:15, Alex Keda wrote:
> 05.05.2010 16:08, Andrea Venturoli пишет:
>> On 05/05/10 13:46, Alex Keda wrote:
>>> 04.05.2010 17:28, Andrea Venturoli пишет:
>>>> In Makefile, there's:
>>>>
>>>> .if ${PHP_VER} == 5
>>>> USE_PHP+= dom
>>>> .else
>>>> USE_PHP+= domxml
>>>> .endif
>>>>
>>>> However, there is no php52-domxml; should php52-dom be used?
>>>>
>>>> Is the makefile wrong? Should it check for ${PHP_VER}==52?
>>>> Or do I need to use some knob?
>>> /usr/ports/textproc/php52-dom
>>
>> Ok, thanks.
>> So, would the following be ok in the above Makefile?
>>
>> .if ${PHP_VER} == 4
>> USE_PHP+= domxml
>> .else
>> USE_PHP+= dom
>> .endif
>>
>> If you can confirm this is fine, I could file a PR with the patch.
> I think, it OK

Well, I was beaten on this :-)
Many thanks to Daniel for patching this port.

  bye
	av.