Date: Wed, 20 Aug 2003 03:24:12 +0200 (CEST) From: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> To: sos@FreeBSD.org Cc: freebsd-hackers@freebsd.org Subject: Re: Bug FreeBSD 4.8 ATA driver Message-ID: <Pine.LNX.4.44.0308200258580.16761-100000@artax.karlin.mff.cuni.cz> In-Reply-To: <Pine.LNX.4.44.0308200130120.12189-100000@artax.karlin.mff.cuni.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Aug 2003, Mikulas Patocka wrote:
> Hi
>
> I am reading FreeBSD ATA drivers because I want to use them as base for my
> ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8,
> there is line
>
> if (!((pci_read_config(parent,0x40,4)>>(ch->unit<<8))&0x4000)) {
>
> if ch->unit is 1, config word is shifted by 256 bytes, which gives
> undefined result in C. How was this meant? What should it do?
>
> Mikulas
Another weird thing: variable word44 is set but never used.
Mikulas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.44.0308200258580.16761-100000>