Date: Mon, 31 Aug 2009 10:26:25 -0700 From: "Li, Qing" <qing.li@bluecoat.com> To: <stef@memberwebs.com>, "freebsd-net@FreeBSD.org" <freebsd-net@freebsd.org> Subject: RE: [patch] Unbreak setfib + routing daemons Message-ID: <B583FBF374231F4A89607B4D08578A430527800B@bcs-mail03.internal.cacheflow.com> In-Reply-To: <200908311702.n7VH2iHI022732@whisker.bluecoat.com> References: <200908311702.n7VH2iHI022732@whisker.bluecoat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Stef, I am not sure if this patch is complete. There are other commands through the routing socket that can trigger routing messages. For example, issuing "ifconfig" to add and remove interface addresses. At the moment these types of routing messages do not have=20 a fib associated with them, which may need fixing. -- Qing > -----Original Message----- > From: owner-freebsd-net@freebsd.org [mailto:owner-freebsd- > net@freebsd.org] On Behalf Of Stef Walter > Sent: Monday, August 31, 2009 10:03 AM > To: freebsd-net@FreeBSD.org > Subject: [patch] Unbreak setfib + routing daemons >=20 > Currently route messages are sent to all listeners of PF_ROUTE, > regardless or which FIB the listener socket was started on. >=20 > The upshot of this is that one can't really use routing daemons > together > with multiple FIBs. The routing daemon sees the messages from the > alternate FIBs and rapidly gets confused. >=20 > In the future, someone might decide to expose FIB numbers in the route > messages themselves. This could allow routing daemons to filter them > out. Such a solution might be appropriate for FreeBSD 9.x and later, as > it would likely break API and ABI. In any case, I'm not really > qualified > to argue the merits/problems of such an approach, and coding it is > beyond my abilities... >=20 > Attached is a patch which fixes this problem in a simple way. It limits > route messages to listening PF_ROUTE sockets on the same FIB that the > route message was for. It compiles and works on 7.1+ and 8.0 and > CURRENT. >=20 > FreeBSD PR: >=20 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/134931 >=20 > How can I help this get into FreeBSD? It would be awesome if this fix > or > one like it made it in before the 8.0 release. >=20 > Cheers, >=20 > Stef
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B583FBF374231F4A89607B4D08578A430527800B>