From owner-cvs-all@FreeBSD.ORG Fri Jan 25 15:58:10 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1B6D16A46D; Fri, 25 Jan 2008 15:58:10 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id 69C3D13C45A; Fri, 25 Jan 2008 15:58:10 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1JIQMY-0009bM-ES; Fri, 25 Jan 2008 15:21:02 +0000 Date: Fri, 25 Jan 2008 15:21:02 +0000 From: Ceri Davies To: Mike Makonnen Message-ID: <20080125152102.GD6064@submonkey.net> References: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="32u276st3Jlj2kUU" Content-Disposition: inline In-Reply-To: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2008 15:58:10 -0000 --32u276st3Jlj2kUU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 25, 2008 at 03:06:26PM +0000, Mike Makonnen wrote: > mtm 2008-01-25 15:06:26 UTC >=20 > FreeBSD src repository >=20 > Modified files: > etc rc.subr=20 > Log: > If the rc.conf(5) variable for a script is not enabled do not fail > silently. Display a message that the command wasn't run and make > possible suggestions for what to do. Any chance that we could make this behaviour dependent on some other variable (or not do it)? It's going to make booting look pretty nasty. Ceri > | @@ -606,6 +606,9 @@ run_rc_command() > | # > | if [ -n "${rcvar}" -a "$rc_arg" !=3D "rcvar" ]; then > | if ! checkyesno ${rcvar}; then > | + echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to " > | + echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' " > | + echo "instead of '${rc_arg}'." > | return 0 > | fi > | fi --=20 That must be wonderful! I don't understand it at all. -- Moliere --32u276st3Jlj2kUU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHmf5eocfcwTS3JF8RAo4pAKDEG3ssFCM0r4aKaGqf0nWy9qtGCgCgjVs3 1HKXpzGmeWuEOnYPKnoAglA= =4tXH -----END PGP SIGNATURE----- --32u276st3Jlj2kUU--