Date: Mon, 13 Apr 2020 22:22:38 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: Renato Botelho <garga@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r529260 - in head/net: ndpi ndpi/files ntopng ntopng/files Message-ID: <0c55e4aa-4625-2565-08b7-d091d907f732@FreeBSD.org> In-Reply-To: <d4d3f054-134c-d2cb-c54e-282971b0ed18@FreeBSD.org> References: <202003271521.02RFLFM3097811@repo.freebsd.org> <4f0e8f32-d9a8-b7bc-2368-1f4c7392a7c4@FreeBSD.org> <5695ea34-b527-c42e-958c-6f701cb694ff@FreeBSD.org> <d4d3f054-134c-d2cb-c54e-282971b0ed18@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13/04/20 21:48, Renato Botelho wrote: > On 13/04/20 15:03, Guido Falsi wrote: >> On 13/04/20 19:46, Renato Botelho wrote: >>> On 27/03/20 12:21, Guido Falsi wrote: >>>> Author: madpilot >>>> Date: Fri Mar 27 15:21:15 2020 >>>> New Revision: 529260 >>>> URL: https://svnweb.freebsd.org/changeset/ports/529260 >>>> >>>> Log: >>>> - Update nDPI to 3.2.d20200324 >>>> - Update ntopng to 4.0.d20200326 >>>> Reported by: Victor Hooi <victorhooi@yahoo.com> >>>> >>>> Deleted: >>>> head/net/ntopng/files/patch-scripts_lua_examples_sqlite.lua >>>> Modified: >>>> head/net/ndpi/Makefile >>>> head/net/ndpi/distinfo >>>> head/net/ndpi/files/patch-example_Makefile.in >>>> head/net/ntopng/Makefile >>>> head/net/ntopng/distinfo >>>> head/net/ntopng/files/patch-configure.seed >>>> head/net/ntopng/pkg-plist >>> >>> After this change it's failing to build on 12-armv7, at least on pfSense >>> jails, with following error: >>> >>> src/ParsedFlow.cpp:130:14: error: invalid operands to binary expression >>> ('lua_Number' (aka 'double') and 'double') >>> version = htons(lua_tonumber(L, -1)); >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> It's actually right. Maybe on other archs compiler inplicitly casts this >> to an int. >> >> Could you try putting an explicit cast to uint16_t there? > > Sure, I will try. Also I got a suggestion to replace lua_tonumber() by > lua_tointeger(). I can try both and let you know. > I'm not expert about lua, so I did not know there is a lua_tointeger. That looks like a cleaner fix, and I can try to upstream that. Thanks! -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0c55e4aa-4625-2565-08b7-d091d907f732>