From owner-svn-ports-all@freebsd.org Tue Jun 18 11:04:18 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9979115B5E42; Tue, 18 Jun 2019 11:04:18 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A6756F65D; Tue, 18 Jun 2019 11:04:18 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id D469CCF8D; Tue, 18 Jun 2019 11:04:17 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 487C7943466; Tue, 18 Jun 2019 11:04:15 +0000 (UTC) Date: Tue, 18 Jun 2019 13:04:14 +0200 From: Mathieu Arnold To: =?utf-8?Q?T=C4=B3l?= Coosemans Cc: Mathieu Arnold , bapt@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r503385 - head/Mk/Scripts Message-ID: <20190618110414.ngqcgv4gydfkmk6z@ogg.in.absolight.net> References: <201906031257.x53Cvi9P092541@repo.freebsd.org> <20190615170158.489616a4@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qzmheo4mipeqazyc" Content-Disposition: inline In-Reply-To: <20190615170158.489616a4@kalimero.tijl.coosemans.org> User-Agent: NeoMutt/20180622 X-Rspamd-Queue-Id: 3A6756F65D X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2019 11:04:18 -0000 --qzmheo4mipeqazyc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 15, 2019 at 05:01:58PM +0200, T=C4=B3l Coosemans wrote: > On Mon, 3 Jun 2019 12:57:44 +0000 (UTC) Mathieu Arnold > wrote: > > Author: mat > > Date: Mon Jun 3 12:57:44 2019 > > New Revision: 503385 > > URL: https://svnweb.freebsd.org/changeset/ports/503385 > >=20 > > Log: > > Use UCL for pkg-message > > =20 > > Remain backward compatible but use ucl for the pkg-messages, which al= lows to: > > - append messages one after the other > > - only print message on delete, install, upgrade from a version to an= other > > =20 > > If pkg-message starts with a [ we consider it should be a valid ucl f= ile > > =20 > > The format is the following: > > [ > > { message: "Always print" }, > > { message: "package being removed", type: remove }, > > { message: "package being installed", type: install }, > > { message: "package is being upgraded", type: upgrade }, > > { message: "Upgrading from lower than 1.0", maximum_version: "1.0", t= ype: upgrade }, > > { message: "Upgrading from higher than 1.0", minimum_version: "1.0", = type: upgrade }, > > { message: "Upgrading from >1.0 < 3.0", maximum_version: "3.0", minim= um_version: "1.0", > > ] > > =20 > > Because it is ucl one can use some sugar like: > > [ > > { message =3D < > formatted > > message 'with fancy things' > > EOD > > }, > > } >=20 > Can this be extended to include these fields: > opsys: > osversion: > arch: > options: I am not sure adding more fields is a good idea. It should remain simple, otherwise there is a risk of the pkg-message syntax getting bloated, and it is bound to be misused, especially as the use case would be very rare. It would probably be better to add files to _PKGMESSAGES when the case you want to handle presents itself. --=20 Mathieu Arnold --qzmheo4mipeqazyc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl0IxS1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhJ3xAAmvvcZnoEG1nTSBavb7oN9f5sDB324W6TZhH0dO+GQMYA0LJ+KzERAKES s5TzUE5PK4BhwWhgiJOsQsY3+qUe1+RjsFdDf6RG4IoufNFvD5NNmDR5Jq2s0JF+ Gxmi0VFNtvdSAgb5WpYHxhn4qfflD5sxsGf60rJs4wIq1AJpI+oXmU9ILqExYmtK q2kkQM2DXP7zLGge+25UHyDak9GTGoYsEzakPjgJVjquG8PgmJcpCTNx0bGcrfW/ yvIMAjO7b3JGHCso7I/Lj69kTiQKzsUAmnQPFmuPMvoXI07Nfkr006kC5NVhQLMr wCzgyNxuws37paIPTJj8v3TMv52K2TdkMu5lMylW8Yc5ji5CJL1eIi3yY053v7f7 AcAQlSNQ1mUXk4qTLrgv6x7ie1NfULsTFlJoibzCmsoqnfj0KBTgkzbEds4R9u7B bmUhwWaaBmYd/dbZ4wXZbw8bJXvsFM6HNwt+uW9sOpaL/CpivJoksUBVn0IROQpq 2BfyoBntgOxj3QW9IxnmRMkO4Er5a1ZKtYV0a0lIPQew4EQDaBz480DPBjmkwwMr k4VXAP0ERJV37NMcepsqa2qZDB+pD1d+/FJGZmD1enOZtjAUiyLXEd01zQPZNR6A prtvmXbn8c5eoBoXKiw/FnMcKLVDKIdKtCQz+awF8wgY9jNw2Do= =APjW -----END PGP SIGNATURE----- --qzmheo4mipeqazyc--