Date: Tue, 31 Mar 2009 11:38:53 -0500 From: Robert Noland <rnoland@FreeBSD.org> To: "N.J. Mann" <njm@njm.me.uk> Cc: freebsd-x11@FreeBSD.org Subject: Re: Xorg 7.4 crashes on exit Message-ID: <1238517533.8491.371.camel@balrog.2hip.net> In-Reply-To: <20090331151657.GA898@titania.njm.me.uk> References: <20090330201109.9CE521CC09@ptavv.es.net> <1238445388.8491.358.camel@balrog.2hip.net> <20090331151657.GA898@titania.njm.me.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-JJx7tuyRNAnmgBtB/A7Q
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Tue, 2009-03-31 at 16:16 +0100, N.J. Mann wrote:
> Hi Robert,
>=20
>=20
> In message <1238445388.8491.358.camel@balrog.2hip.net>,
> Robert Noland (rnoland@FreeBSD.org) wrote:
> > On Mon, 2009-03-30 at 13:11 -0700, Kevin Oberman wrote:
> > > > From: Robert Noland <rnoland@FreeBSD.org>
> > > > Date: Mon, 30 Mar 2009 14:54:45 -0500
> [snip]
> > > >=20
> > > > Is this on CURRENT or STABLE and do you know at least approximately=
when
> > > > you started seeing the issue?
> > > >=20
> > >=20
> > > It is on stable and I THINK it started when I updated my system to
> > > 7.2-PRERELEASE last week. My previous Stable was on February 7 and it
> > > pre-dated the Xorg-1.5.3 server update on the system.
> > >=20
> > > I normally update ports daily, but I did delay the Xorg update for a
> > > week or two to let dust settle.
> >=20
> > There are a lot of changed in that window... I really hope that this
> > doesn't fix it, but could you try reverting:
> >=20
> > balrog% svn diff -c r189669
> > Index: drm_drv.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- drm_drv.c (revision 189668)
> > +++ drm_drv.c (revision 189669)
> > @@ -131,7 +131,7 @@
> > .d_poll =3D drm_poll,
> > .d_mmap =3D drm_mmap,
> > .d_name =3D "drm",
> > - .d_flags =3D D_TRACKCLOSE | D_NEEDGIANT
> > + .d_flags =3D D_TRACKCLOSE
> > };
> > =20
> > static struct drm_msi_blacklist_entry drm_msi_blacklist[] =3D {
>=20
> I was not sure whether you wanted Kevin, me or both of us to try the
> above, so I tried it anyway. :-) It has no visible affect here at all.
> I double checked I had patched the right file and even re-compiled
> (after doing a rm -rf /usr/obj and a make clean) and re-installed the
> resulting kernel. No change.
>=20
> Are there any debug messages I can enable to help you out here?
Yes, I'm not seeing any change here either. So, I don't think that we
have a locking or ordering issue. Are the effects on shutdown a
problem? I think it may have more to do with the fact that we have
released memory before we have switched display modes on shutdown. I
can reproduce the strange color effects on this i915, but haven't hit a
case where it created any sort of problem.
robert.
>=20
> Cheers,
> Nick.
--=20
Robert Noland <rnoland@FreeBSD.org>
FreeBSD
--=-JJx7tuyRNAnmgBtB/A7Q
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)
iEYEABECAAYFAknSRx0ACgkQM4TrQ4qfROOvWQCePhXjlrJaL3oKMhm1tYYtgLgL
/YAAoIPmpJfUtKslNeD476zTJkab/bVL
=c4fb
-----END PGP SIGNATURE-----
--=-JJx7tuyRNAnmgBtB/A7Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1238517533.8491.371.camel>