From owner-cvs-all Sat Jun 23 11:14:15 2001 Delivered-To: cvs-all@freebsd.org Received: from silby.com (cb34181-a.mdsn1.wi.home.com [24.14.173.39]) by hub.freebsd.org (Postfix) with ESMTP id E55E437B406 for ; Sat, 23 Jun 2001 11:14:12 -0700 (PDT) (envelope-from silby@silby.com) Received: (qmail 23554 invoked by uid 1000); 23 Jun 2001 18:14:11 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 23 Jun 2001 18:14:11 -0000 Date: Sat, 23 Jun 2001 13:14:11 -0500 (CDT) From: Mike Silbersack To: Matt Dillon Cc: "Jonathan Lemon Alfred Perlstein" , Mike Silbersack , , , , Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_output.c tcp_subr.c tcp_timer.c tcp_usrreq.c tcp_var.h In-Reply-To: <200106231730.f5NHUNd73058@earth.backplane.com> Message-ID: <20010623131152.I23528-100000@achilles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 23 Jun 2001, Matt Dillon wrote: > Yes, there's no question bzero() should be removed. The subroutine > overhead alone, never mind it doing anything, is enough to blow away > any benefit. Hence: > > Test3 - man load w/ptrs 35.73 nS/loop > Test4 - mlptrs & bzero 161.60 nS/loop > > Ouch! Of course, us old timers also see the fact that the entire > subroutine runs dozens of instructions in less then a microsecond and > say "ooooh, cool...". > > -Matt Wow! Thanks for the optimization, I hadn't considered that bzero could be so slow. I'm about to take off right now, I'll see if I can mock up some benchmarks of the overall performance of tcp_output when I get back on Monday. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message