From owner-cvs-src@FreeBSD.ORG Mon Apr 11 09:11:28 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6525116A4CE; Mon, 11 Apr 2005 09:11:28 +0000 (GMT) Received: from obsecurity.dyndns.org (CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.194.102.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2080C43D2F; Mon, 11 Apr 2005 09:11:28 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id AA05051E1C; Mon, 11 Apr 2005 02:11:26 -0700 (PDT) Date: Mon, 11 Apr 2005 02:11:26 -0700 From: Kris Kennaway To: Harti Brandt Message-ID: <20050411091126.GA6125@xor.obsecurity.org> References: <200504110720.j3B7KAIx034955@repoman.freebsd.org> <20050411074021.GA85675@xor.obsecurity.org> <20050411101216.N97775@beagle.kn.op.dlr.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <20050411101216.N97775@beagle.kn.op.dlr.de> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Kris Kennaway Subject: Re: cvs commit: src/usr.bin/make cond.c cond.h for.c for.h parse.c parse.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2005 09:11:28 -0000 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2005 at 11:07:28AM +0200, Harti Brandt wrote: > KK>I assume you've tested that this doesn't cause problems for anything > KK>in the ports collection? >=20 > I didn't test all of the ports collection - just a number of ports. But I= =20 > grepped the ports infrastructure and the ports Makefile* for problematic= =20 > constructs and found one problem that now shows up (under certain=20 > conditions) instead of beeing hidden: >=20 > mail/dspam > mail/dspam-devel >=20 > both of them use >=20 > . elseif ... >=20 > This has been intepreted by make as a plain .else without any warning up= =20 > to now. Now it is just ignored when the .if defined (WITH_MYSQL40) ... is= =20 > false and give an error if it is true. I'll inform the maintainer about= =20 > this. >=20 > There may be of course ports that use our make to build. In any case the= =20 > change to the .else and .endif clauses just give a warning so the ports > maintainer have time to fix this. What could break is the use of=20 > .undefFOO but I don't expect many of them. I really hope this doesn't cause problems, but based on historical precedent I expect that it will. In future, please coordinate troublesome make changes with us (portmgr) so we can test them first and avoid destabilizing the ports collection for the users. Kris --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCWj8+Wry0BWjoQKURAlWLAKCp5QMOJioTBmJCSzF4JmhgPnQHagCgu8Hj zPuu9ivHUOvJf4pu9jYqcGk= =JMq8 -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--