From owner-cvs-all@FreeBSD.ORG Tue Mar 30 23:27:31 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7307A16A4CE; Tue, 30 Mar 2004 23:27:31 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DA4F43D3F; Tue, 30 Mar 2004 23:27:31 -0800 (PST) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i2V7RVGe084002; Tue, 30 Mar 2004 23:27:31 -0800 (PST) (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i2V7RVDk084001; Tue, 30 Mar 2004 23:27:31 -0800 (PST) (envelope-from peter) Message-Id: <200403310727.i2V7RVDk084001@repoman.freebsd.org> From: Peter Wemm Date: Tue, 30 Mar 2004 23:27:31 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/amd64/gen makecontext.c signalcontext.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2004 07:27:31 -0000 peter 2004/03/30 23:27:31 PST FreeBSD src repository Modified files: lib/libc/amd64/gen makecontext.c signalcontext.c Log: Fix Yet Another 16 byte stack alignment bug. Thankfully, this one is solved by a simple 'make world'. The signalcontext function was going to the trouble of generating an even 16 byte alignment, but in fact it needed to be odd aligned to simulate the 8-byte return address having been pushed by the caller. This fixes yet another group of crashes in applications using libpthread. And yet again, it was my fault all along. While here, rename the duplicate internal ctx_wrapper() functions to makectx_wrapper() and sigctx_wrapper() so that traces aren't ambiguous. Revision Changes Path 1.3 +3 -3 src/lib/libc/amd64/gen/makecontext.c 1.3 +7 -7 src/lib/libc/amd64/gen/signalcontext.c