From owner-freebsd-current Mon Jan 20 5: 4:43 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 304B637B401 for ; Mon, 20 Jan 2003 05:04:42 -0800 (PST) Received: from relay1.macomnet.ru (relay1.macomnet.ru [195.128.64.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F4FB43ED8 for ; Mon, 20 Jan 2003 05:04:41 -0800 (PST) (envelope-from maxim@FreeBSD.org) Received: from news1.macomnet.ru (news1.macomnet.ru [195.128.64.14]) by relay1.macomnet.ru (8.11.6/8.11.6) with ESMTP id h0KD4ae9477244; Mon, 20 Jan 2003 16:04:37 +0300 (MSK) Date: Mon, 20 Jan 2003 16:04:36 +0300 (MSK) From: Maxim Konovalov To: Wiktor Niesiobedzki Cc: current@FreeBSD.org Subject: Re: Dummynet messages In-Reply-To: <20030119224311.GB89748@mail.evip.pl> Message-ID: <20030120160354.P91305@news1.macomnet.ru> References: <20030119224311.GB89748@mail.evip.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23:43+0100, Jan 19, 2003, Wiktor Niesiobedzki wrote: > Hi, > > sys/netinet/ip_dummynet.c: > 975: if (q->avg >= fs->max_th) { /* average queue >= max threshold */ > (...) > 984: } else { > 985: q->count = -1; > 986: printf("- drop"); > 987: return 1 ; > 989: } > > is quite meaningless. Shouldn't be it at least DEB(printf("- drop")? Or > better "drop - max_th exceeded"? > > Just a small proposition, I was quite confused, when I saw this message. Fixed in rev. 1.61 sys/netinet/ip_dummynet.c, thanks. -- Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org, +7 (095) 796979 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message