From owner-dev-commits-src-all@freebsd.org Fri May 21 14:43:31 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9514634504; Fri, 21 May 2021 14:43:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fmq9H12xfz3w7S; Fri, 21 May 2021 14:43:30 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.66.148.124]) by shaw.ca with ESMTPA id k6N3l4ZxxiLmnk6N5lAWYc; Fri, 21 May 2021 08:43:29 -0600 X-Authority-Analysis: v=2.4 cv=W+Nb6Tak c=1 sm=1 tr=0 ts=60a7c711 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=8nJEP1OIZ-IA:10 a=5FLXtPjwQuUA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=Gai371H0N15RG5sVgL4A:9 a=wPNLvfGTeEIA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 465BDA01; Fri, 21 May 2021 07:43:25 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 14LEhO0e099047; Fri, 21 May 2021 07:43:25 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202105211443.14LEhO0e099047@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Marcin Wojtas cc: Jessica Clarke , shawn.webb@hardenedbsd.org, Marcin Wojtas , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: af949c590bd8 - main - Disable stack gap for ntpd during build. In-reply-to: References: <202105211334.14LDYqoa004343@gitrepo.freebsd.org> <04F25FD0-7863-4AC1-A257-EF0F1EB90659@freebsd.org> Comments: In-reply-to Marcin Wojtas message dated "Fri, 21 May 2021 16:11:25 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Fri, 21 May 2021 07:43:24 -0700 X-CMAE-Envelope: MS4xfCn6psuItIPV0g+P+/I1oYNYBtBppOQPS2TwASh9XC5AiXRNbAuxv0Mw2uBb1QgQ2p93nBkDXN7+/rnhQadCgyPMXJy0phr4r1G6gX0lhsn2x+e6Fg22 PWd3sXI+yzGhxB7ED5FRPvMf6JTgQYixAAEznEgUw1K8pOB/DRFYVwadCbAit4d8wN0Xt9SufETDz73lYXqUgF7P4nY6WWV0hVb0alXwEXZaH2a5pvbwn8ix FcufhegnoEtESnAteiOk+wYN4vcgoKIjTJsrhI5UcjwCJs8FcTwQ5bLvpsv3UzYxskfxDVkXIxSXPeVz4ivxB5jmMienxKBtGq4Tq7rjCrP9F32HZWSD+vfy 2HizAQCEnTtFjId/Uw6X//IsMfV6LNsGGRiJg3we8lXMn91woEX1ZNwT7a/iw6Fq4UXq8lrI X-Rspamd-Queue-Id: 4Fmq9H12xfz3w7S X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 14:43:31 -0000 In message , Marcin Wojtas writes: > Hi Jess > > pt., 21 maj 2021 o 15:39 Jessica Clarke napisał(a): > > > > On 21 May 2021, at 14:34, Marcin Wojtas wrote: > > > > > > The branch main has been updated by mw: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=af949c590bd8a00a5973b5875d7e > 0fa6832ea64a > > > > > > commit af949c590bd8a00a5973b5875d7e0fa6832ea64a > > > Author: Marcin Wojtas > > > AuthorDate: 2021-05-21 09:29:22 +0000 > > > Commit: Marcin Wojtas > > > CommitDate: 2021-05-21 13:33:06 +0000 > > > > > > Disable stack gap for ntpd during build. > > > > > > When starting, ntpd calls setrlimit(2) to limit maximum size of its > > > stack. The stack limit chosen by ntpd is 200K, so when stack gap > > > is enabled, the stack gap is larger than this limit, which results > > > in ntpd crashing. > > > > Isn’t the bug that the unusable gap counts as usage? > > > > Jess > > > > An alternative solution was submitted > (https://reviews.freebsd.org/D29832), so that to extend the limit for > ntpd, but eventually it was recommended to simple disable the stack > gap for it until it's fixed upstream (see the last comment in the > linked revision). D29832 doesn't work. D29832 addressed the *already solved* stack gap issue in ntpd. The problem people failed to realize was that it wasn't stack gap but PIE. Enabling PIE regardless of the stack gap sysctl setting always resulted in the error. Ultimately a sledgehammer approach was the only way to address it. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.