From owner-p4-projects@FreeBSD.ORG  Fri Feb  3 07:50:11 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5068116A423; Fri,  3 Feb 2006 07:50:11 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0AA2016A420
	for <perforce@freebsd.org>; Fri,  3 Feb 2006 07:50:11 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A516343D46
	for <perforce@freebsd.org>; Fri,  3 Feb 2006 07:50:10 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k137oAxH067112
	for <perforce@freebsd.org>; Fri, 3 Feb 2006 07:50:10 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k137oAIN067109
	for perforce@freebsd.org; Fri, 3 Feb 2006 07:50:10 GMT
	(envelope-from imp@freebsd.org)
Date: Fri, 3 Feb 2006 07:50:10 GMT
Message-Id: <200602030750.k137oAIN067109@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 90962 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Feb 2006 07:50:12 -0000

http://perforce.freebsd.org/chv.cgi?CH=90962

Change 90962 by imp@imp_Speedy on 2006/02/03 07:50:03

	Nits, mostly comments.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#23 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#23 (text+ko) ====

@@ -22,6 +22,18 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/* TODO: (in no order)
+ *
+ * 1) detach
+ * 2) Free dma setup
+ * 3) Turn on the clock in pmc and turn on pins?  Turn off?
+ * 4) Setup multicast filters
+ * 5) Setup RX buffers in ateinit_locked
+ * 6) Interrupt bits as appropriate
+ * 7) Keep track of the mbufs in flight on TX and free them in the ISR.
+ * 8) Need to sync busdma goo in atestop
+ */
+
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD$");
 
@@ -85,10 +97,6 @@
 	struct mbuf *rx_mbuf[ATE_MAX_RX_BUFFERS]; /* RX mbufs */
 	bus_addr_t rx_desc_phys;
 	eth_rx_desc_t *rx_descs;
-
-	// XXX bogus
-	int intr;
-
 	struct	ifmib_iso_8802_3 mibdata; /* stuff for network mgmt */
 };
 
@@ -517,7 +525,6 @@
 	int status;
 	int i;
 		
-	sc->intr++;
 	status = RD4(sc, ETH_ISR);
 	if (status == 0)
 		return;