From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar  4 16:19:32 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B0808106566B;
	Tue,  4 Mar 2008 16:19:32 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 708808FC13;
	Tue,  4 Mar 2008 16:19:32 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m24GI6hF071895;
	Tue, 4 Mar 2008 09:18:06 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 04 Mar 2008 09:18:34 -0700 (MST)
Message-Id: <20080304.091834.201564687.imp@bsdimp.com>
To: keramida@ceid.upatras.gr
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20080304160006.GB95950@kobe.laptop>
References: <20080304154542.GC61036@kobe.laptop>
	<20080304.085245.2040341894.imp@bsdimp.com>
	<20080304160006.GB95950@kobe.laptop>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: hackers@FreeBSD.org, rwatson@FreeBSD.org
Subject: Re: Comments on pmake diffs for building on Linux
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2008 16:19:32 -0000

In message: <20080304160006.GB95950@kobe.laptop>
            Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
: On 2008-03-04 08:52, "M. Warner Losh" <imp@bsdimp.com> wrote:
: > In message: <20080304154542.GC61036@kobe.laptop>
: >             Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
: > : Nice!  Thank you Robert.  Can I copy parts of this and add them to the
: > : autoconf glue I'm adding now?
: > :
: > : To test just cpp(1) stuff, autoconf supports AC_PREPROC_IFELSE() too,
: > : which I used when I tried writing a check for __FBSDID():
: > :
: > :   AC_PREPROC_IFELSE(
: > :     [AC_LANG_PROGRAM([[#include <sys/cdefs.h>
: > :   #ifndef __FBSDID
: > :   #error No __FBSDID definition.
: > :   #endif]])],
: > :     [AC_DEFINE([HAVE_FBSDID_MACRO], [1],
: > :        [Define to 1 if you have the __FBSDID macro.])])
: > :
: > : I can probably improve a bit the queue.h check using what you wrote
: > : above and AC_PREPROC_IFELSE().
: >
: > The alternative to uglifying the make sources with #ifdefs would be to
: > just always use the compat includes when building...  No autoconf
: > needed, and minimal changes to the base make, if any.
: 
: True.  I'll try to keep #ifdef changes down to the absolutely _minimum_
: amount of changes.  It will make repeated merged from usr.bin/make much
: easier, for example :)

Lemme put together a package for all this and see how few ifdefs I can
do it with...

Warner