From owner-svn-src-head@freebsd.org Thu Jun 9 13:27:40 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57ED9B6FA70; Thu, 9 Jun 2016 13:27:40 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0102.outbound.protection.outlook.com [65.55.169.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DC0B147B; Thu, 9 Jun 2016 13:27:38 +0000 (UTC) (envelope-from sjg@juniper.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xDCiGBeN1j2Sfh6Ezz9l3T94tJH+VnGYNeRJkwSOCho=; b=b3lkwUmXJ3goj5s5O2kdlwiuB90HthQuGo3wHRgRWYyudDs94GIsq3Vxv2WK8ZF15Gjn6EUvQM8FOZjscxLV3rWDQ2i04YH92PBCSOWZiwpOdBZBMaJn/jFmLgYChXItWik2RPNXFT0YNr5VBCVg/8aCtvrI0TCGsSjS2PjeWSw= Received: from SN1PR0501CA0034.namprd05.prod.outlook.com (10.163.126.172) by CO2PR0501MB808.namprd05.prod.outlook.com (10.141.244.142) with Microsoft SMTP Server (TLS) id 15.1.511.8; Thu, 9 Jun 2016 13:27:35 +0000 Received: from BN1BFFO11OLC004.protection.gbl (2a01:111:f400:7c10::1:177) by SN1PR0501CA0034.outlook.office365.com (2a01:111:e400:52fe::44) with Microsoft SMTP Server (TLS) id 15.1.511.8 via Frontend Transport; Thu, 9 Jun 2016 13:27:35 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=juniper.net; FreeBSD.org; dkim=none (message not signed) header.d=none;FreeBSD.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.19 as permitted sender) Received: from P-EMFE01C-SAC.jnpr.net (66.129.239.19) by BN1BFFO11OLC004.mail.protection.outlook.com (10.58.145.15) with Microsoft SMTP Server (TLS) id 15.1.497.8 via Frontend Transport; Thu, 9 Jun 2016 13:27:34 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMFE01C-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 9 Jun 2016 06:25:34 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.16.84]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id u59DPYE93342; Thu, 9 Jun 2016 06:25:34 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 2B1E0385508; Thu, 9 Jun 2016 06:25:34 -0700 (PDT) To: Glen Barber CC: , , , , Subject: Re: svn commit: r301713 - head/sys/dev/random In-Reply-To: <20160609130108.GN2323@FreeBSD.org> References: <201606090150.u591ohZa019497@repo.freebsd.org> <20160609130108.GN2323@FreeBSD.org> Comments: In-reply-to: Glen Barber message dated "Thu, 09 Jun 2016 13:01:08 -0000." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <90182.1465478734.1@kaos.jnpr.net> Content-Transfer-Encoding: quoted-printable Date: Thu, 9 Jun 2016 06:25:34 -0700 Message-ID: <90183.1465478734@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:66.129.239.19; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(199003)(24454002)(189002)(50226002)(450100001)(9686002)(4326007)(81156014)(76176999)(106466001)(92566002)(81166006)(69596002)(189998001)(68736007)(2950100001)(8746002)(76506005)(77096005)(19580395003)(110136002)(19580405001)(4001430100002)(8676002)(2906002)(117636001)(23726003)(8936002)(47776003)(50986999)(105596002)(586003)(46406003)(5008740100001)(50466002)(86362001)(5003600100002)(11100500001)(97756001)(2810700001)(107886002)(6806005)(87936001)(97736004)(53416004)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:CO2PR0501MB808; H:P-EMFE01C-SAC.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11OLC004; 1:ey0m9MDITY7LOpU0gFK8qh1UXiQIMdB0s7DONd7mE3BGFCM67lvSPNJvZOQx4JpCkJGdeONdDqo4uWxea9zr7PevHKm36ei5cuMXyR4La7cIHt0/hYsQM/8l4Vir4rfXqBdEcYS0I1rm+f7zG1AhjJec0raZd8h9O27SGZXKYnTG7LkYDDYIY+cpshQWGOJaQk13G99pzfszz0SwGUo4KrtBAl9jhBd3ZzSXgqCMrsQiTU5sne286P/9tec+9x0OYIt0CxC+FL8Rm+mUrE8qY8x4RWc78nZEqOjZ6hWjK1jvi+7W9WBGdKc48O7ZDcx5Xed3EFuYK5O6UfRiuHywC1oO0t85M/vtasK28H8vlq+LKJC4Dvf+4fCV2KATPC9zrQcVa1e38TvLukAQw0mfRFmqx71BAy2XaF5BjmmFVCk2nFAQgF4G1dMoPk0W2h/KXqOtlpk1TNCayANHT/2+L6+K5P98/PxXosku6AskC/o= X-MS-Office365-Filtering-Correlation-Id: 2cadebca-38d4-4f75-c540-08d39069d199 X-Microsoft-Exchange-Diagnostics: 1; CO2PR0501MB808; 2:6FfD+ez32lP5YnpyI1OFZcQpwTkftUl1F5qiIabXeMwBHI3mrU4gKYpT6yM2RE/CJipkuE6Q+NsDDQcsAYYI3zzC8+RrCMngcEegOooyZeAy2iaTKGW/T1qIR/djmmD8VoY+VQv+fEQ+aJ90JXA4XZoYDduwkQVwDKi747Ak+THq0mlU/mUtJd0xndWGBsZe; 3:W8OkwqdH0wBnpEHKstKKFupQWIhDCeP5yqe15omPw3FHXeqcbjVidsD2OqISFT2eb6LywGdi47lQS9XgGbLLX1nzXdACg9SeozSHquqQegK5Zm+CAZDa5/w4SJASTWCm9RvdKZcoqwmKsxVtwM+kNUEOxY0n88L0n8lK6BDzumD9ry+pNTwT13tf1aGTUsu6cP341XadTupzPCHWmIUKEnyjFgS70hVwSVGc71QMKkA=; 25:05JHLqkOCsxIP1Kj3DG+EX2iYKnVMRwp5tqiEm4GILg4MP6MMtG1hAhLgLwCdrfiAuRonEr/rzJwyM8r6ykbVwvBo2SRH4MMX0CDIlLFykHMA4cg6bFZWmqQM6hvJB2X/TXNaQxxmVgE16oG9OZ+NWKGUdAlS2TcRA/ph1O740M9VmygwkBc4frti0xyTwJ/kp2V6FP3661t5XX0e9BwEleG66r6gT3GPlNIGhPPomFGUFHE6015pgfQ+GJ0i4cNp8RtlbEJ3h4zbDxNf4MaihuMgLwoiie3EheXeV7yXIoPm9yHL2Cw2tNqs+ge0FxnoIO5WKETWmOjsKbYVRDDZWt0AAoV0bUYKX+cJLGUSwA4i7sNn/1Wlm2TCwblyeap1ymS5vnQ2eCp2YFubYKteNRP21xc6l34dE+6+0GY22Q= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR0501MB808; X-Microsoft-Exchange-Diagnostics: 1; CO2PR0501MB808; 20:vXMGl6VZmNW/+JmWbdNf4gCfAkgHom8vMqBr9jYgaJeMebm0j3bYazSi7tUfCt22ZJV+a+LNn70RKFfaBBQ7YQdLKvhQnzm91I48D8biYBKNHKdRwRIGyM8W6QTHg8zLSHo+PSg4TbstP9rL99oyptVYzLid4hCGJTl7sRFfSzAuTlKD+FVWhP+l/AUR3GHqoFLcjS/oyfc3Zu6jZyGGL0t9aNQouPZSKbsKWnn/ElVa/wLFn4PWRMUkqrb7CUv/X1ohaAy6S9Ba0L/V4m+fkwHb/uuJkmz/mjjtaX7NmyiNDoKApwvhNQocnymN+3wCNghZvOTvjVdtr9TIKXwGqHpjp3BkBcw/eyuGhTAQc5wz6mkaYGMgrC5qad9lhdqTIIYAdHoJxw3SP11H40BBANRqC1UMr+DllT+/hXWCSfNIUwO1Q1OMEyfBeiN2GAJ5S2UxlRBQqGNOERHQXYY8Wx2CpAUUTh/X6guE5DLVHNrbC/tp58ho2uBTo5Lo4xnu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(13024025)(13017025)(13023025)(13018025)(8121501046)(13015025)(10201501046)(3002001)(6055026); SRVR:CO2PR0501MB808; BCL:0; PCL:0; RULEID:; SRVR:CO2PR0501MB808; X-Microsoft-Exchange-Diagnostics: 1; CO2PR0501MB808; 4:fGt1z1eGEBE3UIVUaTRbd1QcF6QFyC0o4QnTPSenMs9cgg7tdvEP19aypM2Hj7BXE4F2brIM5+hrN0vHmbH7GM+gIBv7/V0DFp3Dvjo+vhRwfHgUeUtM0Ug7ouge28q2dGI6bPtzOTokMZmV8fvnvffFPMZVs5amPduKPDmTPxvNzhe4L8OnMCoGJHzI4tpUXL668412zOw13m3/keZEGos8pQmovGRK1yyfWYioA4VF90/r9bbTPrw7OY5I+Y9FBE6iCTKC6ijjeUR9lmTLH0sv+xOdbTCDD8KF6ZXW3y4qLTaFAaD7wethiCNJ80Gc7yIWaQ1LVbEzCjzbPJYNgv0arVkWY2h2uU6FrhODX3rtn02wjbbFfki5qMYGYYvjrXDqgaCti0/sSNstqhOUtm6MOK82oyQ+R3JNE+0OhL7K8pVC574/IdAWMwaHA+fwpQefwePczo80N2f6uoWzr5Xm2jHgEmfuIFiWWXzJWb0= X-Forefront-PRVS: 0968D37274 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR0501MB808; 23:VTPTpRv7feBFuVSFNNrLra1YZJeTr6kVpI22B/Tq?= =?us-ascii?Q?CiTjR9LQTK7lCbemJ+QVGoO3mp8ymKjrd0lFJIj8H5jdvyYnukeNOByJ17Oj?= =?us-ascii?Q?GYEeeirWzucIOSc3SD+71suNxsf5jEXYvZhI3TnFmgInsPZte6Kdpebk8LrT?= =?us-ascii?Q?bIhjQicVeSs61dgr1dp14kZnGnOcdBAEpbHSNQYEvIkAacIf/7eRDK+a/W4t?= =?us-ascii?Q?ZSGdTorHGYAjVop9YpF5NL29aLvRln/q7pZ+We7KoFru9DSnK/Hwvi4jmERe?= =?us-ascii?Q?zZcqkf+VZCWnL8ReCAbtMotNaiMqiTHCy2YJZEJdgDUr1hS6iWZwys9KvbH4?= =?us-ascii?Q?geDAr995Lg58BJctPbwRjVQJzRQkv5wMOG3nAeSZJvuRwp21mZ2gnE+ODq46?= =?us-ascii?Q?NucS/PZOi6DQFNqGgABpkLHCX7Amc2dficYHALwOaTHh5TaldDyMYY7zsWmo?= =?us-ascii?Q?V3XIfvfyyocDAEObAs0jpV7NRiA/k6/cv1pLC/1DxuJA3XfIcePyTFAiYnbF?= =?us-ascii?Q?xPaEmXfTpYEJ3fNPwG72TyN1teGfxbkEGpT9FA+5ghGDXtxg+3prWp1Ud87d?= =?us-ascii?Q?yDvYjakpjz9q9HhK9IajDnhHpAWnx4Nv4n4W69/c+VeJWxbrje0QPZ0fuz3L?= =?us-ascii?Q?y7g1WwEA7jyBOYS9EVKgNfQw8Cp+uYwcJ63RKj4LSbzHHcuyDwchz3AU/O52?= =?us-ascii?Q?jGN6j9CWOb8BRlHCb8ur42cqg9iKc2JcB6QMnx3X4Ptb+hnkV9Fuxr02ELQO?= =?us-ascii?Q?yCwEqdzTxq582pCzYDuFvgOLAIU7QhU9ySI4hZ43RVyl8iDeTX6nmd201xvw?= =?us-ascii?Q?+5gaOuclwwh8TPNerZUOkQyzDfBumzKQYhDChEkcbQN4cI9omFdAm+E7YYhQ?= =?us-ascii?Q?PXg7knVMewd10bpcKztFBIvmcaZPvehP+xtrHuXClWyq/T+sKzYfOcOPtoF2?= =?us-ascii?Q?di0Ni2xlupI/NoNIA/Z41Ez7GNhAqBTLboODtpvWslNAWBAamawH9R7tbNaY?= =?us-ascii?Q?IMbcqLH0lyW+lBhuuS8JyfmEXZKSahHkOM45/4ner9q45zCF0qlLezCTeQ6E?= =?us-ascii?Q?rbbXyFvXHD880v38zv/74sGGI8jd8EKMkebu4XIMsZHYs14ZNNMsE6RhKNNC?= =?us-ascii?Q?bCNmyGA5DN0GrI3t9Bb6B+IbwCKamaBKWV4xa7Jd5rcl5mLf8bNe8LR1oJzs?= =?us-ascii?Q?cFJxiOVavu4ZsDA5MNob9ON2HSv1JrUn79Oys/cSjkEFbRgw3Qn6S2GrMg?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR0501MB808; 5:nNXdIzmP69RwPAOeft2u3D4WV6qLr6XHxHngKPfl0n7TFX9ZZLWE9ZvmPWnOJV2f3sxrztdbkRpRN9XPawMQTy+AHy8MCAlzotarPGZKsxh3tMOsGhRW9urMEoFpf/j4K3nagXVA7tQa04Z7HwfmMA==; 24:F0kK2RyW76Gd41Iues5+xhvMnGxHucj/LxOcMVdzwrdAy/0htQWDBUsbmQG1ZEoSxjmxAJu52dE2aolJYxXq7Lsxme0jKWBK/85EqG1zwiE=; 7:nJJKlTKroR7Mw/7bDuskDudtehzOEca9stMLVNtkL4s1aGiD29JV7CTif8qS5S5dZIrL/3cP8fafws3PVQmfixU83mgOUoD6M0qhQ2QxC5oCSOEoPAzIYoBOn3z9SZhYEaolnPyXv0SbNdWoo7f60r6YNnHIItpaixfle57PzP31hmkA8m0s5Xb+8TRLUtWXJS3v+qyIkf0NH1WXWYRdQnXtDA/kDfunUC6iIcU2tMg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2016 13:27:34.8109 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[P-EMFE01C-SAC.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR0501MB808 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 13:27:40 -0000 Glen Barber wrote: > > = > > -void read_rate_increment(u_int); > > +void random_harvest_queue(const void *, u_int, u_int, > > + enum random_entropy_source); > > +void read_rate_increment(u_int); > > = > > #define RANDOM_HARVESTQ_BOOT_ENTROPY_FILE "/boot/entropy" > > = > = > This breaks sparc64. Looks like defined(DEV_RANDOM) is relevant. Wrapping the prototype in random_harvestq.h in #ifndef DEV_RANDOM would avoid this issue. But backing out until we check if that fixes the original issue steve hit is probably best? > = > cc1: warnings being treated as errors > In file included from /usr/src/sys/modules/random_other/../../dev/random= /other_algorithm.c:62: > /usr/src/sys/dev/random/random_harvestq.h:47: warning: redundant redecla= ration of 'random_harvest_queue' [-Wredundant-decls] > /usr/src/sys/sys/random.h:99: warning: previous declaration of 'random_h= arvest_queue' was here > = > Glen > =