From owner-svn-src-head@freebsd.org  Mon Jun 26 13:20:18 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5AA6D86E08
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Mon, 26 Jun 2017 13:20:18 +0000 (UTC) (envelope-from ed@nuxi.nl)
Received: from mail-yb0-x234.google.com (mail-yb0-x234.google.com
 [IPv6:2607:f8b0:4002:c09::234])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7424078FF9
 for <svn-src-head@freebsd.org>; Mon, 26 Jun 2017 13:20:18 +0000 (UTC)
 (envelope-from ed@nuxi.nl)
Received: by mail-yb0-x234.google.com with SMTP id b81so335172yba.2
 for <svn-src-head@freebsd.org>; Mon, 26 Jun 2017 06:20:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=nuxi-nl.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=Mp4aTWP1no6X7UGAtb8KuyWTZlbxIbNvHU2JsUvRgb4=;
 b=Vaxdju/k+7WuYR08/qe08a1W77tlY3kN5cnxMYGeAaXuQpndXcmihpcsAhX2vAUqT9
 BtyiZG2QLxRTV+cGM7tNKKhMlhzPXvX2WBlKbl0w7zUmmKlQbEhMRWqay/LdJD4uIYGR
 Ypl3dRwOfJ+650Bvc6DD8ILmMg/7MwsB6KMJc8INB/LSgx7rglPvzysbIQ3AZ0eDaqeQ
 REp1Yg1cxNhLh+9ZoKajWeJlIK4CtrZo79cl8XmPqywuqkyZAKA9PBlDc5Op05yckNmh
 ssXMa5JZM1EdJtZP54GHaWKAIFEuk0X6VTNH8kRMpidQV3Dk3qNi9iJ9J29+wPQRBHeU
 5ixA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=Mp4aTWP1no6X7UGAtb8KuyWTZlbxIbNvHU2JsUvRgb4=;
 b=iWImT0M1aFtujHMbPDA9yp9jHC/CsTPpfFse4VPnvv8v+wBDMcfqIxf+328xkEYpeZ
 S/nCtFDayvQmFkc/y+HJDd4na0A6z2sB/lt93RroTvzQHI50oY+UVMM8T4ljsQFbz9vK
 iIK6j2UruYgsK7KdKD9S1BhiOQBNKDc6ewlKXwLdjgRtTj1QYfGUrnbPkSPrna5CBHM9
 GzmRDMj5ompfCJeNC08Si5YiSNqs8xw5uidh5G4ptLikhSlY3/MBMQrlsUJruCt2T72W
 MrNgtMVgfYEnBif0gzAA+2HmV/FbTuf2ZkaFjEFyaGPttnVthSHfAPn4Dt8Ryta6QNhV
 4r6Q==
X-Gm-Message-State: AKS2vOyijZFtXTxvWi/X/M9wvP7FjFbu3rlViRf0HDoBu/xeQS825jTC
 0ca7smW+YQqidUq3mrc9fgN+sm1BTQFU
X-Received: by 10.37.37.131 with SMTP id l125mr129887ybl.53.1498483217527;
 Mon, 26 Jun 2017 06:20:17 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.13.216.142 with HTTP; Mon, 26 Jun 2017 06:19:47 -0700 (PDT)
In-Reply-To: <201706261314.v5QDEfHj014897@repo.freebsd.org>
References: <201706261314.v5QDEfHj014897@repo.freebsd.org>
From: Ed Schouten <ed@nuxi.nl>
Date: Mon, 26 Jun 2017 15:19:47 +0200
Message-ID: <CABh_MK=C-j+2agWt+8ed_prLPZVpLtg1SsB6w+AiQy3hV5VoBw@mail.gmail.com>
Subject: Re: svn commit: r320360 - head/usr.bin/resizewin
To: Edward Tomasz Napierala <trasz@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jun 2017 13:20:18 -0000

2017-06-26 15:14 GMT+02:00 Edward Tomasz Napierala <trasz@freebsd.org>:
> +       /* Disable echo, drain the input, and flush the output */
>         if (tcgetattr(fd, &old) == -1)
>                 exit(1);

> +       if (tcsetattr(fd, TCSAFLUSH, &new) == -1)
>                 exit(1);

Would it make sense to print diagnostics here?

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717