From owner-svn-ports-head@freebsd.org Wed Mar 22 05:11:11 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D599D150CE; Wed, 22 Mar 2017 05:11:11 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46D0B91E; Wed, 22 Mar 2017 05:11:10 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v2M5BAen067197 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Mar 2017 22:11:10 -0700 (PDT) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v2M5BADU067196; Tue, 21 Mar 2017 22:11:10 -0700 (PDT) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 21 Mar 2017 22:11:10 -0700 From: Gleb Smirnoff To: Cy Schubert Cc: Gerald Pfeifer , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436576 - in head/emulators/wine-devel: . files Message-ID: <20170322051110.GC23308@FreeBSD.org> References: <20170322041508.GA23308@FreeBSD.org> <201703220509.v2M59ZxR029779@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201703220509.v2M59ZxR029779@slippy.cwsent.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 05:11:11 -0000 On Tue, Mar 21, 2017 at 10:09:35PM -0700, Cy Schubert wrote: C> In message <20170322041508.GA23308@FreeBSD.org>, Gleb Smirnoff writes: C> > On Tue, Mar 21, 2017 at 10:35:39PM +0100, Gerald Pfeifer wrote: C> > G> > But without the bump I can't enforce rebuild for FreeBSD 12 users, can I C> > ? C> > G> C> > G> Well, it did not build for FreeBSD 12 users without your patch, or C> > G> did I misunderstand? C> > C> > The version built earlier won't work properly on newer head, so we C> > want users to rebuild. I thought bumping PORTREVISION is the right C> > thing to do. C> C> Generally, if it's broken and the commit fixes the build, no PORTREVISION C> bump is needed. C> C> If the ABI in base changes, then a PORTREVISION bump is also required. Thanks for explanation. The latter is the case (ABI changed), so bump was useful. -- Totus tuus, Glebius.