From nobody Fri Jul 18 19:16:14 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bkKJv2CfJz62gJS; Fri, 18 Jul 2025 19:16:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bkKJt4CHvz4243; Fri, 18 Jul 2025 19:16:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752866174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vC6fJ69LCjkkcvkKERndkU8xTgUN+Z12Q1dIcAgB2QM=; b=ThEbHDpJhNKpev2FQpRKD2cGRj3NJiKoFAQDqvEEYgrXH4VJnZcAZhE/Z7eb+eVIG31PL/ Ic+dL5dtjNAKQLOIu3jht9RhQDX+zhDVpNJrT6rdLUIL4ZJ4YBJCaze6+M6bwN24cZx93I 1hYSEfa+fpZR10w5we8w5i/iyXM2nRuvW2GZ3JoVOPgbzjrPt4LZbyzWKNQha7r856Xhlb Jip/Sdu03g4cvSEQqg/NaJbXGzs5MggwEqzZVW4mOApu4Kg7C5IUQBFSdsaZpimaMPlPxS Gohr5GJEBcKE5VcmzvyhvmtOVJtefOfCM09tB856cLgsrOwcMDHm2hcPwcag6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752866174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vC6fJ69LCjkkcvkKERndkU8xTgUN+Z12Q1dIcAgB2QM=; b=GTr+Jq0Ko51Hlhupr/CGnlgD1fdHJeSrpR5MF4R4jyojHDpMcH+skL6ghxiUPnaKocaKuq Y+3Tnw0xd9W0dZu09dsozFbLLqgOELOBWHwYmhbzm2pmXz9xBvw7ZGrpFxwpm6yB0f8hX0 VPhaimhAJaal9qe+YhUNBD8ENypXCmViKz9hRiET8/STj19NkO1BmVzZiPplbXD4Zug1y4 kkyRBjAxZ4YGDXkkSZbiw2YVtgkYuPw9ptsr/rCUfRuE2/k6+nN2psx4XNW4rQawvTgOum TeJjHYcoJ8c2yR7okXTqf3VLFJAGRKdA0QCZzfwCMuLCYjfdEjC/SMlcYKOJIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752866174; a=rsa-sha256; cv=none; b=S0GfxZBDd1Bvn3FcPeUEfhzVM+fhJZV7+oh1tD7sx+9hqqMVItaLVMUeKS7VpkPOp1tN9O Ma9SXSJrP0rki1lhVAy91Rp5eGZFpbUtZGfegyzgRiaEB0ipnmUwqxoG5Pynn0tR+oQAip 55HyoeVKxVwKi4YHQ19yWqa2L1dRsYeP4aEaKiH5PyvDEyvmdfOiPiLJ9z6b9cHp+K5q4j g3Ff0lw3V9A9MFGnPJvgDUu62WGHeHvswqHQv5DVPYQGarmqELpNTp9ZazLmsphkJMkTZr UPdIdzLkHIr/BXG7m0KqD2FppFxUsDH8vbSD1TIg9QQcsny2UN3RGSumITaXMQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bkKJt3qBmztn8; Fri, 18 Jul 2025 19:16:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56IJGEWi000919; Fri, 18 Jul 2025 19:16:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56IJGEjo000916; Fri, 18 Jul 2025 19:16:14 GMT (envelope-from git) Date: Fri, 18 Jul 2025 19:16:14 GMT Message-Id: <202507181916.56IJGEjo000916@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 160becc7dc3d - main - ice: Add broadcast filter while creating VF List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 160becc7dc3db59b2f43eb8b6e02019c94821f40 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=160becc7dc3db59b2f43eb8b6e02019c94821f40 commit 160becc7dc3db59b2f43eb8b6e02019c94821f40 Author: Krzysztof Galazka AuthorDate: 2025-01-15 23:43:43 +0000 Commit: Warner Losh CommitDate: 2025-07-18 19:16:16 +0000 ice: Add broadcast filter while creating VF Filter for unicast MAC address is configured with a virtual channel message, but filter for a broadcast traffic was missing. It caused issues with e.g. ARP. Signed-off-by: Krzysztof Galazka Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1573 --- sys/dev/ice/ice_iov.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/dev/ice/ice_iov.c b/sys/dev/ice/ice_iov.c index 75b50af0d1bc..0d04c06b3140 100644 --- a/sys/dev/ice/ice_iov.c +++ b/sys/dev/ice/ice_iov.c @@ -369,6 +369,14 @@ ice_iov_add_vf(struct ice_softc *sc, uint16_t vfnum, const nvlist_t *params) goto release_imap; } + /* Add the broadcast address */ + error = ice_add_vsi_mac_filter(vsi, broadcastaddr); + if (error) { + device_printf(sc->dev, "Unable to add broadcast filter VF %d VSI: %s\n", + vfnum, ice_err_str(error)); + goto release_imap; + } + ice_iov_ready_vf(sc, vf); return (0);