Date: Fri, 09 Aug 2024 17:38:02 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 280696] net/kea: fix build with libc++ 19 Message-ID: <bug-280696-7788-EXwPT11ALh@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-280696-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-280696-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280696 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D4c580629baba91b4dd22baa556c7684= 43ef4150d commit 4c580629baba91b4dd22baa556c768443ef4150d Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-08-08 18:34:30 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-08-09 17:36:42 +0000 net/kea: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes net/kea to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: In file included from edns.cc:9: In file included from ../../../src/lib/exceptions/exceptions.h:11: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ../../../src/lib/dns/name.h:727:16: note: in instantiation of templ= ate class 'std::basic_string<unsigned char>' requested here 727 | NameString ndata_; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ `NameString` is defined as `std::basic_string<unsigned char>`, which is no longer possible. So redefine it as a `std::vector<unsigned char>` instead. This requires a few adjustments in other places: adjusting the arguments for the `assign()` method, which for `std::vector` takes a begin and end iterator, instead of a begin iterator and a size, and replacing the `append()` method with an equivalent `insert()`. These changes have also been sent upstream [2]. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-remov= als [2] https://gitlab.isc.org/isc-projects/kea/-/merge_requests/2410 PR: 280696 Approved by: apevnev@me.com (maintainer) MFH: 2024Q3 (cherry picked from commit eddc2f815b3fac6d363e93e7f9ec4dabc816b0c9) net/kea/files/patch-src_lib_dns_name.cc (new) | 56 +++++++++++++++++++++++= ++++ net/kea/files/patch-src_lib_dns_name.h (new) | 11 ++++++ 2 files changed, 67 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280696-7788-EXwPT11ALh>