From owner-cvs-all  Sun Aug 19 17: 6:20 2001
Delivered-To: cvs-all@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP
	id BAE9637B414; Sun, 19 Aug 2001 17:06:12 -0700 (PDT)
	(envelope-from mike@coffee.q9media.com)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.3) id f7K0SI749612;
	Sun, 19 Aug 2001 20:28:18 -0400 (EDT)
	(envelope-from mike)
Date: Sun, 19 Aug 2001 20:28:18 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: Josef Karthauser <joe@tao.org.uk>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: CVSROOT commit_prep.pl
Message-ID: <20010819202818.D49129@coffee.q9media.com>
Mail-Followup-To: Mike Barcroft <mike@FreeBSD.org>,
	Josef Karthauser <joe@tao.org.uk>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
References: <200108191257.f7JCvE474098@freefall.freebsd.org> <20010819145733.B48972@coffee.q9media.com> <20010819200043.B43816@tao.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010819200043.B43816@tao.org.uk>; from joe@tao.org.uk on Sun, Aug 19, 2001 at 08:00:43PM +0100
Organization: The FreeBSD Project
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Josef Karthauser <joe@tao.org.uk> writes:
> On Sun, Aug 19, 2001 at 02:57:33PM -0400, Mike Barcroft wrote:
> > On Sun, Aug 19, 2001 at 05:57:14AM -0700, Josef Karthauser wrote:
> > > joe         2001/08/19 05:57:14 PDT
> > > 
> > >   Modified files:
> > >     .                    commit_prep.pl 
> > >   Log:
> > >   Tabulate per style.perl(7).
> > >   
> > >   Revision  Changes    Path
> > >   1.33      +110 -101  CVSROOT/commit_prep.pl
> > 
> > There are also non-whitespace changes in this commit.  In future could
> > you please split commits like these into two seperate ones to make
> > diffs easier to read.
> 
> Are you sure?  Some lines have been adjusted to fit into 80 columns,
> but none of the logic has been changed.

Yes.

[...]
@@ -82,97 +82,104 @@
 #
 ############################################################
 
+# Write a single line to a file.
 sub write_line {
-    local($filename, $line) = @_;
-    open(FILE, ">$filename") || die("Cannot open $filename, stopped");
-    print(FILE $line, "\n");
-    close(FILE);
+	my $filename = shift;	# File to write to.
+	my $line = shift;	# Line to write to the file.
+
+	open FILE, ">$filename" or die "Cannot open $filename, stopped\n";
+	print FILE "$line\n";
+	close FILE;
 }
[...]

From looking at the first section of the diff, I see local() changed
to use 'my' and some comments that have been added.  I didn't see
anything wrong with the commit, but when using 'cvs diff' it's hard to
see what has changed.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message