Date: Tue, 7 Mar 2023 09:16:06 +0900 From: Koichiro Iwao <meta@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230307001606.j7vhypsfrohkz62s@icepick.vmeta.jp> In-Reply-To: <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <ZAWLnDz5cb4vIR/j@FreeBSD.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 06, 2023 at 08:55:01PM +0100, Mathieu Arnold wrote:
> On Mon, Mar 06, 2023 at 08:52:54PM +0100, Mathieu Arnold wrote:
> > On Mon, Mar 06, 2023 at 11:25:06PM +0900, Koichiro Iwao wrote:
> > > On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote:
> > > > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote:
> > > > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff
> > > > >
> > > > > security/softether5: add DEBUG option
> > > > >
> > > > > [...]
> > > > > +.include <bsd.port.options.mk>
> > > > > +
> > > > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk
> > > > > +# just set WITH_DEBUG=yes, CMAKE_ARGS+=-DCMAKE_BUILD_TYPE=Debug takes no effect.
> > > > > +.if ${PORT_OPTIONS:MDEBUG}
> > > > > +WITH_DEBUG= yes
> > > >
> > > > We do not expose this via options. To build debug package, just
> > > > "make -DWITH_DEBUG", don't ask users to fiddle with options.
> > > >
> > > > ./danfe
> > >
> > > Really? What's the difference exposing ports vs not?
> >
> > WITH_DEBUG is a global user facing knob, it must never be activated via
> > options.
>
> Sorry, bad wording, it must never be set in any Makefile, wether
> options, flavor, or whatever. It is not a port setting, that one sets
> in a Makefile, it is a user setting that one sets in make.conf.
Understood. Other ports which have DEBUG option mostly don't set
WITH_DEBUG but just add something like --enable-debug to *_ARGS. This
kind of DEBUG options are allowed, right (ex. lang/php8[012])?
BTW, I didn't know WITH_DEBUG_PORTS. It's very handy. I tell the user
who requested DEBUG option to use it.
Thanks,
--
meta <meta@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230307001606.j7vhypsfrohkz62s>