From nobody Tue Mar 7 00:16:06 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVwwF2nryz3wZxY; Tue, 7 Mar 2023 00:16:13 +0000 (UTC) (envelope-from meta@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVwwF2BRnz3k5F; Tue, 7 Mar 2023 00:16:13 +0000 (UTC) (envelope-from meta@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678148173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/uDQQdSfwRF4d0aBGdIT+5JogzZyUPHALQpFd05fh8I=; b=fc7KWO5zIlR9PNHk757FEZv3SvdkeCAsdghLltweFxl7HlktdTwJ8KcaPp7PAajmybJX3v aWj51Jpoc0rlKpqPmo57kdKq9JjuL/ghHLa1dD1/3GHg4EV0ulYnkhgEzvMO6CQYN8Hfee m7y8F9ht0mxRO4P7OVNjYHxQx2/43cWRCwpPryDK9v0KoCuIeZkzyHq7xX854Fj4TvJ1Bi Qedn2Dudnzw9TsMxiCUvl3uJiWZqOp3EIdq94X5SkmiLMGaO7LC30DJUyJL9jojMQHGMjc P5GPMZTH7gWOK/wj+2vkxWMHYl/I+jFufxXK9OSB1gW5YR6uVs/CeUsNUpHfxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678148173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/uDQQdSfwRF4d0aBGdIT+5JogzZyUPHALQpFd05fh8I=; b=nJkFFnd2kP5NQkbWvqmDgW10ht1cWaaXrqAx0F12rC3fZVe8OSRWGZRLD/VKp5jqvL+jDj 3vYV8JvCYXCEy78+eiBmR7EgAFAdBGKITQKE8bm/hMXl1mkwmC6ty3SsBTsitRgPwe9u7P Ck2RpF49p51X0R7AtYBwovacBO8yI+AEn1PNaPoxnU0qYceONrxOvfT4YmS2+B+O3febbE +zyizdl/FG2twPS9jEf6lz/pPc8Jjch2vnV5oFrB7mNcBqcJVP675dKk164H/jI4NGBJR4 88JohlKv7ZgLhrpeXC69yd77KrE7n0U0/srvBggyrGXzQYvbH4vy1FOdQfdmoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678148173; a=rsa-sha256; cv=none; b=bZF1MLdkJH/xH3aR+AH9dWlmL9qfimpBnntlQS5slJt0Oeo/NQV3qXXBOkvGE+VN8lxf6a 77Ku6dJg4iKxmGk2hiAkouWwE6BWj1NLERcEW9/2Jo9y8O9eljuw904IO2hbAlohsykKeQ Z7Q31IY22d1e61lj0qsE7TNaVoakFA+ZwUH9RhMm4RXroqSIsISHmKQE54WRJJUupkiJQW 0yGyyYl9AGYvD+gV2ZmlxdRz2YcTdm1dHxSALb+L064eB7NxsT+kSotkhqy4BP4jgnl/bL 8GVJrfK1nIaZcUDXYg7xlxNb7llbmRro9EBMT+OYKD7ZOl6+DyhOTHzgxT2k+Q== Received: from icepick.vmeta.jp (unknown [IPv6:2403:bd80:c100:411:e10f:5f62:d735:93a1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PVwwC3xXyzKhT; Tue, 7 Mar 2023 00:16:11 +0000 (UTC) (envelope-from meta@FreeBSD.org) Date: Tue, 7 Mar 2023 09:16:06 +0900 From: Koichiro Iwao To: Mathieu Arnold Cc: Alexey Dokuchaev , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230307001606.j7vhypsfrohkz62s@icepick.vmeta.jp> X-Operating-System: FreeBSD 13.2-STABLE amd64 References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> X-ThisMailContainsUnwantedMimeParts: N On Mon, Mar 06, 2023 at 08:55:01PM +0100, Mathieu Arnold wrote: > On Mon, Mar 06, 2023 at 08:52:54PM +0100, Mathieu Arnold wrote: > > On Mon, Mar 06, 2023 at 11:25:06PM +0900, Koichiro Iwao wrote: > > > On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote: > > > > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote: > > > > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff > > > > > > > > > > security/softether5: add DEBUG option > > > > > > > > > > [...] > > > > > +.include > > > > > + > > > > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk > > > > > +# just set WITH_DEBUG=yes, CMAKE_ARGS+=-DCMAKE_BUILD_TYPE=Debug takes no effect. > > > > > +.if ${PORT_OPTIONS:MDEBUG} > > > > > +WITH_DEBUG= yes > > > > > > > > We do not expose this via options. To build debug package, just > > > > "make -DWITH_DEBUG", don't ask users to fiddle with options. > > > > > > > > ./danfe > > > > > > Really? What's the difference exposing ports vs not? > > > > WITH_DEBUG is a global user facing knob, it must never be activated via > > options. > > Sorry, bad wording, it must never be set in any Makefile, wether > options, flavor, or whatever. It is not a port setting, that one sets > in a Makefile, it is a user setting that one sets in make.conf. Understood. Other ports which have DEBUG option mostly don't set WITH_DEBUG but just add something like --enable-debug to *_ARGS. This kind of DEBUG options are allowed, right (ex. lang/php8[012])? BTW, I didn't know WITH_DEBUG_PORTS. It's very handy. I tell the user who requested DEBUG option to use it. Thanks, -- meta