From owner-svn-src-all@FreeBSD.ORG Fri Aug 17 14:28:12 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3D57106564A; Fri, 17 Aug 2012 14:28:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id CA9828FC16; Fri, 17 Aug 2012 14:28:11 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2ED67B96E; Fri, 17 Aug 2012 10:28:11 -0400 (EDT) From: John Baldwin To: Randall Stewart Date: Fri, 17 Aug 2012 08:26:25 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <201208170551.q7H5pkd1025308@svn.freebsd.org> In-Reply-To: <201208170551.q7H5pkd1025308@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201208170826.25123.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 17 Aug 2012 10:28:11 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r239353 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2012 14:28:12 -0000 On Friday, August 17, 2012 1:51:46 am Randall Stewart wrote: > Author: rrs > Date: Fri Aug 17 05:51:46 2012 > New Revision: 239353 > URL: http://svn.freebsd.org/changeset/base/239353 > > Log: > Ok jhb, lets move the ifa_free() down to the bottom to > assure that *all* tables and such are removed before > we start to free. This won't protect the Hash in ip_input.c > but in theory should protect any other uses that *do* use locks. Eh, this is just a nop unless there is a reference counting bug. Only the last reference would free the memory if the reference count is correct, so this is just adding obfuscation by moving the ifa_free() away from the associated TAILQ_REMOVE(). -- John Baldwin