From owner-svn-src-stable@freebsd.org Fri May 25 17:47:41 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7030FEEF2A6; Fri, 25 May 2018 17:47:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BD0F16BB2F; Fri, 25 May 2018 17:47:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w4PHlSb0012051 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 25 May 2018 20:47:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w4PHlSb0012051 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w4PHlSxB012050; Fri, 25 May 2018 20:47:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 25 May 2018 20:47:28 +0300 From: Konstantin Belousov To: Mike Tancsa Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, FreeBSD-STABLE Mailing List Subject: Re: svn commit: r334152 - in stable/11/sys: amd64/amd64 amd64/include dev/cpuctl i386/include x86/acpica x86/include x86/x86 Message-ID: <20180525174728.GI88128@kib.kiev.ua> References: <201805241317.w4ODHOQL068672@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 17:47:41 -0000 On Fri, May 25, 2018 at 01:21:00PM -0400, Mike Tancsa wrote: > On 5/24/2018 9:17 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Thu May 24 13:17:24 2018 > > New Revision: 334152 > > URL: https://svnweb.freebsd.org/changeset/base/334152 > > > > Log: > > MFC r334004: > > Add Intel Spec Store Bypass Disable control. > > > > This also includes the i386/include/pcpu.h part of the r334018. > > > > Hi, > This commit broke my i386 nanobsd kernel. GENERIC kernels build just > fine, but the kernel I have been using for i386 alix and Soekris boxes > no longer builds > > Apart from removing some unneeded drivers from GENERIC, the CPU options > I use are > > > cpu I586_CPU > options CPU_GEODE > ident ALIX_DSK You do not have the SMP option in the config, right ? > > /usr/src/sys/x86/x86/cpu_machdep.c:890:3: error: this function > declaration is not a prototype > [-Werror,-Wstrict-prototypes] > /usr/src/sys/x86/x86/cpu_machdep.c:890:17: error: expected ';' after > expression > CPU_FOREACH(i) { > ^ I forgot about merging r334064.