From owner-freebsd-current@FreeBSD.ORG Wed Aug 18 14:11:45 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0945916A4CE; Wed, 18 Aug 2004 14:11:45 +0000 (GMT) Received: from green.homeunix.org (pcp04371970pcs.nrockv01.md.comcast.net [69.140.223.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F7C243D58; Wed, 18 Aug 2004 14:11:44 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i7IEBiDp024888; Wed, 18 Aug 2004 10:11:44 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i7IEBhAu024887; Wed, 18 Aug 2004 10:11:44 -0400 (EDT) (envelope-from green) Date: Wed, 18 Aug 2004 10:11:43 -0400 From: Brian Fundakowski Feldman To: Ruslan Ermilov Message-ID: <20040818141143.GB1525@green.homeunix.org> References: <200408172029.35506.mjohnston@skyweb.ca> <20040818045206.GD99980@funkthat.com> <20040818062709.GC6348@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040818062709.GC6348@ip.net.ua> User-Agent: Mutt/1.5.6i cc: John-Mark Gurney cc: current@FreeBSD.org Subject: Re: kqueue is safe to use? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2004 14:11:45 -0000 On Wed, Aug 18, 2004 at 09:27:09AM +0300, Ruslan Ermilov wrote: > On Tue, Aug 17, 2004 at 09:52:06PM -0700, John-Mark Gurney wrote: > > Mark Johnston wrote this message on Tue, Aug 17, 2004 at 20:29 -0500: > > > Here's this week's giant summary. As you probably know, a code freeze went > > > into effect first thing on the 17th, which is the main reason for the length > > > of this summary. > > > > Another change you forgot is that I commit patches to make kqueue safe > > to use on -current. This has been a long outstanding problem with > > -current. > > > Would the following be safe to commit now? > > %%% > Index: Makefile > =================================================================== > RCS file: /home/ncvs/src/usr.bin/make/Makefile,v > retrieving revision 1.33 > diff -u -r1.33 Makefile > --- Makefile 12 Aug 2004 11:49:55 -0000 1.33 > +++ Makefile 18 Aug 2004 06:23:06 -0000 > @@ -18,11 +18,10 @@ > CFLAGS+=-DMAKE_VERSION=\"5200408120\" > .if defined(_UPGRADING) > CFLAGS+=-D__FBSDID=__RCSID > +.else > +CFLAGS+=-DUSE_KQUEUE > .endif > > -# XXX: kernel currently broken > -# CFLAGS+=-DUSE_KQUEUE > - > main.o: ${MAKEFILE} > > # Set the shell which make(1) uses. Bourne is the default, but a decent > %%% > > I've been using it for a long time; still works just as safely with regular -CURRENT now as it did with my previous kqueue reimplementation. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\