From owner-freebsd-current@FreeBSD.ORG Wed Oct 9 17:46:54 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 23C8D5CC for ; Wed, 9 Oct 2013 17:46:54 +0000 (UTC) (envelope-from freebsd@allanjude.com) Received: from mx1.scaleengine.net (beauharnois2.bhs1.scaleengine.net [142.4.218.15]) by mx1.freebsd.org (Postfix) with ESMTP id F2EBC28E8 for ; Wed, 9 Oct 2013 17:46:53 +0000 (UTC) Received: from [10.1.1.1] (S01060001abad1dea.hm.shawcable.net [50.70.108.129]) (Authenticated sender: allan.jude@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 8AA651E2EE; Wed, 9 Oct 2013 17:46:52 +0000 (UTC) Message-ID: <525596A7.2090701@allanjude.com> Date: Wed, 09 Oct 2013 13:47:19 -0400 From: Allan Jude User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: "Teske, Devin" Subject: Re: [CFT] Patch to bsdinstall to support root-on-ZFS and GELI References: <52531295.7090700@allanjude.com> <5254D231.5070803@allanjude.com> <13CA24D6AB415D428143D44749F57D720FC4B3F2@LTCFISWMSGMB21.FNFIS.com> In-Reply-To: <13CA24D6AB415D428143D44749F57D720FC4B3F2@LTCFISWMSGMB21.FNFIS.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Oct 2013 17:46:54 -0000 On 2013-10-09 13:21, Teske, Devin wrote: > On Oct 8, 2013, at 8:49 PM, Allan Jude wrote: > >> On 2013-10-07 15:59, Allan Jude wrote: >>> Devin Teske and I have been working on a big patch to bsdinstall to >>> implement installing on a ZFS pool. It supports both GPT and MBR, the 4k >>> sector gnop trick, and optional GELI encryption. We would like to commit >>> this in time for 10.0-BETA1 so it needs some testing to work out any >>> obvious bugs before we send it off to re@ to get it committed. >>> >>> It includes a single configuration menu that allows you to select all of >>> the required details, including which drives to use (gets details from >>> camcontrol, also includes an inspection utility that presents the >>> detailed output of camcontrol inquiry/identify, and gpart show), what >>> ZFS RAID level to use (taking in to consideration the selected number of >>> drives), GPT/mbr, 4k YES/no, GELI yes/NO, pool name, etc. >>> >>> >>> Additional, it includes some other changes to bsdinstall: >>> 1. Change the default to the 'non-standard keyboard mapping' prompt to no >>> 2. Replace the 3 separate dialogs to configure an ipv4 address with just 1 >>> 3. Remove the dialog asking if you wish to enable crash dumps, this >>> feature has been combined into the regular 'services to enable' dialog >>> and enabled by default >>> >>> >>> You can browse the patches here: >>> http://druidbsd.cvs.sf.net/viewvc/druidbsd/bsdinstall_zfs/ >>> >>> I've built a bootonly.iso (10.0-ALPHA4) to make testing easier, >>> available compressed (48 MB) or uncompressed (211 MB): >>> >>> http://www.allanjude.com/bsd/zfsbootonly_2013-10-06.iso.xz >>> >>> http://www.allanjude.com/bsd/zfsbootonly_2013-10-06.iso >>> >>> >>> We look forward to your feedback >>> >> We've made more improvements, including corporating most all of the >> feedback we've gotten so far >> >> >> Outstanding items: >> 1. Apply the changes to ipv6 config the way we did ipv4 >> 2. improve disk identification (model info and serial # instead of one >> or the other) >> 3. Include a helpful message before the GELI step where you have to >> enter your password many times, the user will be less confused if it is >> explained why they have to enter their password 3 * number of disks times > I'm hopeful that we can script the application of a password that we > first prompt for. > > What tool is prompting for a password? Can we not just provide an answer > on stdin? (e.g., echo "$pass" | tool_that_needs_pass) > It is 'geli create' and 'geli attach'. I am not sure if we want to have the password show up in the process list (obviously in the installer this is less of an issue, but) > >> 4. Validate vdev type choice inside the vdev type menu, and warn the >> user if they have made an invalid selection, so they can add more disks >> or chance their selection, without having to try to start the >> installation first > This will be done with fanciness ;D (read: ... --and-widget --infobox ... and > sundry smartness; retaining as much as possible the ability to do things > out of order but never arise at a point of astonishment). > I don't think we need --and-widget, just in the function where we apply the results of the menu selection, we can add a regular --msgbox telling them that their config won't work, and they need to either select more drives or a different vdev type >> 5. Whatever else you guys find wrong tonight >> >> I generated new test images, and attached the patch (which got REALLY >> big when Devin Teske decided to fix "all of the things": >> > And then I merged "all of the things" into HEAD, so the patch-set shrunk > back to its normal size. Now we have global exit codes which will make > merging of code that is based off of Thomas Dickey's samples easier. I am glad to see all of the good ideas, and plans to make everything wonderful, but my biggest concern is getting this over to re@ so it can get in to 10.0-BETA1, the deadline for which is looming (like, tomorrow I think). As such, I have rolled back the patches to netconfig and netconfig_ipv4 (my stuff to reduce the number of dialogs to configure ipv4, it posed some problems with the possible usage of xdialog, and didn't actually offer an option to 'cancel'). I kept Warren's netconfig wireless patch This leaves the only real outstanding problem the keymap thing. I propose changing it from a yes/no/other to a --menu, and hopefully we can find the bug with the display name, or just make it show the keymap name instead. -- Allan Jude