Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Mar 2020 14:19:36 +0100 (CET)
From:      =?UTF-8?Q?Trond_Endrest=C3=B8l?= <trond.endrestol@ximalas.info>
To:        David Wolfskill <david@catwhisker.org>
Cc:        freebsd-stable@freebsd.org, imp@freebsd.org
Subject:   Re: r358661 breaks /usr/src/usr.sbin/amd/include/newvers.sh on stable/12
Message-ID:  <alpine.BSF.2.22.395.2003051418540.80706@enterprise.ximalas.info>
In-Reply-To: <20200305130149.GC1511@albert.catwhisker.org>
References:  <alpine.BSF.2.22.395.2003051348230.80706@enterprise.ximalas.info> <20200305130149.GC1511@albert.catwhisker.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 5 Mar 2020 05:01-0800, David Wolfskill wrote:

> On Thu, Mar 05, 2020 at 01:54:58PM +0100, Trond Endrestøl wrote:
> > The command
> > "sh /usr/src/usr.sbin/amd/include/newvers.sh /usr/src/sys/conf/newvers.sh"
> > is run a part of a normal build, creating config_local.h.
> > 
> > After r358661, I find this in my build logs for stable/12:
> > 
> > eval: 1: Syntax error: end of file unexpected (expecting ")")
> > eval: 1: Syntax error: Error in command substitution
> > ....
> 
> As  Tomoaki AOKI <junchoon@dec.sakura.ne.jp> pointed out (in
> svn-src-stable-12@):
> 
> | This should be MFC'ed with r346022, otherwise usr.sbin/amd
> | does not build.
> 
> (I hand-applied the change, and the build (and suibsequent reboot &
> smoke-test) succeeded.)

Thank you.

-- 
Trond.
From owner-freebsd-stable@freebsd.org  Thu Mar  5 13:55:26 2020
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BCCD26A499
 for <freebsd-stable@mailman.nyi.freebsd.org>;
 Thu,  5 Mar 2020 13:55:26 +0000 (UTC)
 (envelope-from wlosh@bsdimp.com)
Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com
 [IPv6:2607:f8b0:4864:20::732])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48YC1l1LZsz3ywX
 for <freebsd-stable@freebsd.org>; Thu,  5 Mar 2020 13:55:22 +0000 (UTC)
 (envelope-from wlosh@bsdimp.com)
Received: by mail-qk1-x732.google.com with SMTP id y126so1900330qke.4
 for <freebsd-stable@freebsd.org>; Thu, 05 Mar 2020 05:55:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=bsdimp-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=kfATl/W90yq0V7ywHY36F23MDUnHqI7ZFwr+6h/aZPQ=;
 b=g4cH2355/bO/BmYyX3vZLdo3/3BfyL8Jb8S+K7FHWM8906I0rGWjfKZPLWjQhm9LA0
 sBzjmQsV5GtMtL32RUNN0668oJ/vJVnt/E5cX8y/4eWAlVjhImMFKVKyQa1HviDq7PR1
 ybxO+QL2a7pasxjIRYxPROOjcfrxhK8bjZSy0cZc5EYMMw6W7GVaA6UH1iyJ9z9yy7dR
 ZJY3G2FvBc3LlLaqkxVDvPt7E4Yd3nHFeUwZQNTqXSfYXdnNwdXLob95YOYmAhHc4bnh
 tDLGXPOZZ/Z6i9EdXLysrHt6En+uG3w9k5lhO8Cjb9Le/LURbyju8hwAKl/FVp6j1/YV
 IE3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=kfATl/W90yq0V7ywHY36F23MDUnHqI7ZFwr+6h/aZPQ=;
 b=QpaBiMXmIwxz0hfBvwYg8J1L/Cf3RFY1MgvrjLEc7RRalJtHAIJPBlDqhe11+gnrYm
 E7cg7nMjb6zAGd/F4bxR0gqiqVWGFSEyUJFs/J4q6AsUAoFZu7FL3KGLGM3f/4Afpqho
 X4VFBvFvv+pLmSBguJ0ZJh2Ejw8IrKXYdc4weZuaPzXJOLi4qpBly9PZe3PISmS+UFc2
 EyPr80nzsrHSGwAVIlZVuKWXceOAb8WLM3wh9R7ueeHSjeToQVGznbIUrZmAR9VztRI3
 L0J+gw5Z5zHQkItMXYHgaQ1aRtAANxsqIH4a22A4xulz21frREC5p8uocY8DBRA4TYjC
 F12A==
X-Gm-Message-State: ANhLgQ2fIYCNxg+VhtSAeOY+zwh4pxoDfPOKP8LD1wIpmg1n9tZ55U3q
 4rI2Yq2tLoMO0vMEjpCbPEhLIV7bqwLexPAP2EN7PQ==
X-Google-Smtp-Source: ADFU+vtiUtu9bxj+5hn9U/dJCsyrjZ0i5Ig8dttw4HEOttjsqJQJ7TA+V8hP7Yf+ORUrZ0KPOxEqzKDJP28bdhYPJkM=
X-Received: by 2002:a37:8b45:: with SMTP id n66mr8011998qkd.380.1583416520250; 
 Thu, 05 Mar 2020 05:55:20 -0800 (PST)
MIME-Version: 1.0
References: <alpine.BSF.2.22.395.2003051348230.80706@enterprise.ximalas.info>
 <20200305130149.GC1511@albert.catwhisker.org>
In-Reply-To: <20200305130149.GC1511@albert.catwhisker.org>
From: Warner Losh <imp@bsdimp.com>
Date: Thu, 5 Mar 2020 06:55:08 -0700
Message-ID: <CANCZdfoA6v+ETHyztpeivjsezqi4353AMDFrw2ze-aO=5Ns4bA@mail.gmail.com>
Subject: Re: r358661 breaks /usr/src/usr.sbin/amd/include/newvers.sh on
 stable/12
To: David Wolfskill <david@catwhisker.org>,
 =?UTF-8?Q?Trond_Endrest=C3=B8l?= <trond.endrestol@ximalas.info>, 
 FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>,
 Warner Losh <imp@freebsd.org>
X-Rspamd-Queue-Id: 48YC1l1LZsz3ywX
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
 dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623
 header.b=g4cH2355; dmarc=none;
 spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when
 checking 2607:f8b0:4864:20::732) smtp.mailfrom=wlosh@bsdimp.com
X-Spamd-Result: default: False [-4.58 / 15.00]; ARC_NA(0.00)[];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623];
 FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4];
 NEURAL_HAM_LONG(-1.00)[-1.000,0];
 MIME_GOOD(-0.10)[multipart/alternative,text/plain];
 PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org];
 DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[];
 TO_DN_ALL(0.00)[];
 DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+];
 RCVD_IN_DNSWL_NONE(0.00)[2.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org
 : 127.0.5.0]; R_SPF_NA(0.00)[];
 FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com];
 MIME_TRACE(0.00)[0:+,1:+,2:~];
 IP_SCORE(-2.58)[ip: (-9.32), ipnet: 2607:f8b0::/32(-1.86), asn: 15169(-1.65),
 country: US(-0.05)]; 
 ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US];
 FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com];
 RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>;
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Mar 2020 13:55:26 -0000

On Thu, Mar 5, 2020 at 6:01 AM David Wolfskill <david@catwhisker.org> wrote=
:

> On Thu, Mar 05, 2020 at 01:54:58PM +0100, Trond Endrest=C3=B8l wrote:
> > The command
> > "sh /usr/src/usr.sbin/amd/include/newvers.sh
> /usr/src/sys/conf/newvers.sh"
> > is run a part of a normal build, creating config_local.h.
> >
> > After r358661, I find this in my build logs for stable/12:
> >
> > eval: 1: Syntax error: end of file unexpected (expecting ")")
> > eval: 1: Syntax error: Error in command substitution
> > ....
>
> As  Tomoaki AOKI <junchoon@dec.sakura.ne.jp> pointed out (in
> svn-src-stable-12@):
>
> | This should be MFC'ed with r346022, otherwise usr.sbin/amd
> | does not build.
>
> (I hand-applied the change, and the build (and suibsequent reboot &
> smoke-test) succeeded.)
>

I'm rebuilding too with this change and will commit when I confirm it
worked.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.22.395.2003051418540.80706>