From owner-freebsd-multimedia Fri Dec 26 21:56:12 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id VAA05967 for multimedia-outgoing; Fri, 26 Dec 1997 21:56:12 -0800 (PST) (envelope-from owner-freebsd-multimedia) Received: from rah.star-gate.com (rah.star-gate.com [204.188.121.18]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id VAA05950 for ; Fri, 26 Dec 1997 21:55:59 -0800 (PST) (envelope-from hasty@rah.star-gate.com) Received: from rah.star-gate.com (localhost.star-gate.com [127.0.0.1]) by rah.star-gate.com (8.8.8/8.8.8) with ESMTP id VAA02086; Fri, 26 Dec 1997 21:55:51 -0800 (PST) (envelope-from hasty@rah.star-gate.com) Message-Id: <199712270555.VAA02086@rah.star-gate.com> X-Mailer: exmh version 2.0gamma 1/27/96 To: Jonathan Hanna cc: multimedia@freebsd.org Subject: Re: brooktree848.c In-reply-to: Your message of "Fri, 26 Dec 1997 21:32:08 PST." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 26 Dec 1997 21:55:51 -0800 From: Amancio Hasty Sender: owner-freebsd-multimedia@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Will try out your patch tonite if all goes will commit the fix. I have no idea why we have to have the tables in the driver however do you have a reasonable reason why should we separate the frequency tables from the driver? Just thinking that it can be a maintaince nightmare by splitting the driver --- I rather have it all in one place for now because of its narrow use ; however , it we embark on a similar video capture driver projects then yes it will make sense to make the frequency table separate from the driver. Steve Passe wrote that portion of the driver;however, he is currently very busy with the SMP project. Amancio > Two things: > > Just reminding you to commit the following patch to brooktree848.c. Let me know > if I should send it somewhere else. Otherwise, I will have to figure out how > to make local mods to the CVS tree, which could get ugly... > > Why does the brooktree driver have tables of channel assignments in it? Any > reason not to just put them in some /usr/share/... and tune with frequencies? > > > --- brooktree848.c Sat Nov 15 20:52:29 1997 > +++ brooktree848.c.new Tue Dec 23 00:28:49 1997 > @@ -530,6 +530,10 @@ > #define PHILIPS_NTSC_WADDR 0xc6 > #define PHILIPS_NTSC_RADDR 0xc7 > > +/* PLL on a the Philips FR1236MK2 tuner */ > +#define PHILIPS_FR1236_NTSC_WADDR 0xc2 > +#define PHILIPS_FR1236_NTSC_RADDR 0xc3 > + > /* guaranteed address for any TSA5522/3 (PLL on all(?) tuners) */ > #define TSA552x_WADDR 0xc2 > #define TSA552x_RADDR 0xc3 > @@ -3714,6 +3718,7 @@ > #define PHILIPS_SECAM 6 > #define TEMIC_PALI 7 > #define PHILIPS_PALI 8 > +#define PHILIPS_FR1236_NTSC 9 > /* XXX FIXME: this list is incomplete */ > > /* input types */ > @@ -3805,6 +3810,14 @@ > { "Philips PAL I", /* the 'name' */ > TTYPE_PAL, /* input type */ > 0x00, /* PLL write address */ > + TSA552x_SCONTROL, /* control byte for PLL */ > + { 0x00, 0x00 }, /* band-switch crosspoints */ > + { 0xa0, 0x90, 0x30 } }, /* the band-switch values */ > + > + /* PHILIPS_FR1236_NTSC */ > + { "Philips FR1236 NTSC FM", /* the 'name' */ > + TTYPE_NTSC, /* input type */ > + PHILIPS_FR1236_NTSC_WADDR, /* PLL write address */ > TSA552x_SCONTROL, /* control byte for PLL */ > { 0x00, 0x00 }, /* band-switch crosspoints */ > { 0xa0, 0x90, 0x30 } }, /* the band-switch values */ > > > > > Jonathan Hanna