Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Dec 1997 21:55:51 -0800
From:      Amancio Hasty <hasty@rah.star-gate.com>
To:        Jonathan Hanna <pangolin@rogers.wave.ca>
Cc:        multimedia@freebsd.org
Subject:   Re: brooktree848.c 
Message-ID:  <199712270555.VAA02086@rah.star-gate.com>
In-Reply-To: Your message of "Fri, 26 Dec 1997 21:32:08 PST." <XFMail.971226214100.pangolin@rogers.wave.ca> 

next in thread | previous in thread | raw e-mail | index | archive | help
Will try out your patch tonite if all goes will commit the fix.


I have no idea why we have to have the tables in the driver however do
you have a reasonable reason why should we separate the frequency
tables from the driver? Just thinking that it can be a maintaince 
nightmare by splitting the driver --- I rather have it all in one
place for now because of its narrow use ; however , it we embark
on a similar video capture driver projects then yes it will make
sense to make the frequency table separate from the driver.

Steve Passe wrote that portion of the driver;however, he is currently
very busy with the SMP project.


	Amancio
> Two things:
> 
> Just reminding you to commit the following patch to brooktree848.c. Let me know
> if I should send it somewhere else. Otherwise, I will have to figure out how
> to make local mods to the CVS tree, which could get ugly...
> 
> Why does the brooktree driver have tables of channel assignments in it? Any
> reason not to just put them in some /usr/share/... and tune with frequencies?
> 
> 
> --- brooktree848.c      Sat Nov 15 20:52:29 1997
> +++ brooktree848.c.new  Tue Dec 23 00:28:49 1997
> @@ -530,6 +530,10 @@
>  #define PHILIPS_NTSC_WADDR     0xc6
>  #define PHILIPS_NTSC_RADDR     0xc7
>  
> +/* PLL on a the Philips FR1236MK2 tuner */
> +#define PHILIPS_FR1236_NTSC_WADDR      0xc2
> +#define PHILIPS_FR1236_NTSC_RADDR      0xc3
> +
>  /* guaranteed address for any TSA5522/3 (PLL on all(?) tuners) */
>  #define TSA552x_WADDR          0xc2
>  #define TSA552x_RADDR          0xc3
> @@ -3714,6 +3718,7 @@
>  #define PHILIPS_SECAM          6
>  #define TEMIC_PALI             7
>  #define PHILIPS_PALI           8
> +#define PHILIPS_FR1236_NTSC    9
>  /* XXX FIXME: this list is incomplete */
>  
>  /* input types */
> @@ -3805,6 +3810,14 @@
>         { "Philips PAL I",                      /* the 'name' */
>            TTYPE_PAL,                           /* input type */
>            0x00,                                /* PLL write address */
> +          TSA552x_SCONTROL,                    /* control byte for PLL */
> +          { 0x00, 0x00 },                      /* band-switch crosspoints */
> +          { 0xa0, 0x90, 0x30 } },              /* the band-switch values */
> +
> +       /* PHILIPS_FR1236_NTSC */
> +       { "Philips FR1236 NTSC FM",             /* the 'name' */
> +          TTYPE_NTSC,                          /* input type */
> +          PHILIPS_FR1236_NTSC_WADDR,           /* PLL write address */
>            TSA552x_SCONTROL,                    /* control byte for PLL */
>            { 0x00, 0x00 },                      /* band-switch crosspoints */
>            { 0xa0, 0x90, 0x30 } },              /* the band-switch values */
> 
> 
> 
> 
> Jonathan Hanna <pangolin@rogers.wave.ca>






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712270555.VAA02086>