From nobody Mon Dec 12 14:40:55 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NW47C4JZXz4kXYg; Mon, 12 Dec 2022 14:40:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NW47C3tj1z4L8J; Mon, 12 Dec 2022 14:40:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670856055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oowKvh02RbBIANBXNs4ac4uZ1aSZNX/xtRa3mxd222o=; b=QZpjipYi8wlSYzyqBaWXK5YY+sp15Y+OX9kBecqxTNUM6GS7Vk8DcJZokQx2FenrG0v6ni RS2niS1gnTDt7jvwXUb9m2Gb0fymYeDtJSPiEot2AugeL7a5cjOgA+B1Uj73TBRGA9qH1E 2LV38zoMmPTee0d3VO3EFX253XY6XDQuz5KfAJfruwXbLfPRpxcpcPsUN+PFF4MMuMQiIL 5A0zq87i5VnSgSGxf4xVuu9q7RFfzBWWEBvpHkqZoWOM8zhdOlaxhb9AT8xSVXWy+84gYt 5EiELtuLw9tdPKf00qRUrV0AuYKHpL23EyAjAg2gokCZyIlypzimZIgtlxareA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670856055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oowKvh02RbBIANBXNs4ac4uZ1aSZNX/xtRa3mxd222o=; b=ijHG52VEfm/+ZGf2WLvcmPSNQIsGTnzNonNFHxhNCIRu0wDID2HZKU4UjhV5MJkigs19Em VaZ+0eKv0iHDf6+sYKaO8dJkJFGDhVKEApePDv3KRa88bjwigOFsniAq6FsPugj31fGbyk v7/0oPMM4IpOyJctKaul8WGYD87r7IOz+BS6yujNyx46SlDcCG+0rhXo5J+PK8O1ClQ8gQ SRzbQghtMVYA94LH7pwJlOWwZtXrwgeIuO8P1+YD4/nW0efntg+wyBH+gjCoKdJLYL8tXP e5vvO1VsSx3EPVtOwGTohGPmHFshHJclRxJfBNsyiM3XUFUhYteymD1c8V0FRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670856055; a=rsa-sha256; cv=none; b=wVZlZ5gN+XZFB2fm0+dVwEV8+hu3XNz/T7nbdf3ZJ1rsMkOgduU2kLp9ROQfB7uZZ6w9aX BXNUPN4WySWyw8FGWnkba29lD7Yed/JnMM6n/2alRgIJrAHsGoML6JZdnsvprIAqW62/W8 h56Af3Jgdt6C9gyHKLASMtZSXAf+XoRIHy5ouMtdKLO2bIe67MCpVueb4JrAGuawR/4Qk+ 1s2O8DtKOQgl9zBqfpmSW32pkWLbXo0mmgCbP39zz5M8Jv5aPP2edUh003C6rNfJakIpcc son+NseNKdYePTaeeWSOKbxvoEubZAZMQEb1XjYixLTHwBf9trZ8jdGtc05Vqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NW47C2y9YzdS8; Mon, 12 Dec 2022 14:40:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BCEetps080232; Mon, 12 Dec 2022 14:40:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BCEetIJ080231; Mon, 12 Dec 2022 14:40:55 GMT (envelope-from git) Date: Mon, 12 Dec 2022 14:40:55 GMT Message-Id: <202212121440.2BCEetIJ080231@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 08c3ed3469de - stable/13 - heimdal: Properly ix bus fault when zero-length request received List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 08c3ed3469de06199b1a8e2176df3c2e802b0519 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=08c3ed3469de06199b1a8e2176df3c2e802b0519 commit 08c3ed3469de06199b1a8e2176df3c2e802b0519 Author: Cy Schubert AuthorDate: 2022-12-08 23:22:43 +0000 Commit: Cy Schubert CommitDate: 2022-12-12 14:40:33 +0000 heimdal: Properly ix bus fault when zero-length request received Zero length client requests result in a bus fault when attempting to free malloc()ed pointers within the requests softc. Return an error when the request is zero length. This properly fixes PR/268062 without regressions. PR: 268062 Reported by: Robert Morris (cherry picked from commit 3deefb0d147d71047a13ec2328b1b721da2ce256) --- crypto/heimdal/kadmin/server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/heimdal/kadmin/server.c b/crypto/heimdal/kadmin/server.c index 19dfd89d521a..5e01277fe45b 100644 --- a/crypto/heimdal/kadmin/server.c +++ b/crypto/heimdal/kadmin/server.c @@ -473,6 +473,8 @@ v5_loop (krb5_context contextp, ret = krb5_read_priv_message(contextp, ac, &fd, &in); if(ret == HEIM_ERR_EOF) exit(0); + if (in.length == 0) + ret = HEIM_ERR_OPNOTSUPP; if(ret) krb5_err(contextp, 1, ret, "krb5_read_priv_message"); doing_useful_work = 1;